Skip to content

Slowness when using large number of dynamic parameters. Fixes #1537 #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Slowness when using large number of dynamic parameters. Fixes #1537 #2037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Dapper/DynamicParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Data;
using System.Globalization;
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;
Expand Down Expand Up @@ -222,6 +223,9 @@ protected void AddParameters(IDbCommand command, SqlMapper.Identity identity)
}
}

HashSet<string> addedParameters = new HashSet<string>(command.Parameters.Cast<IDbDataParameter>()
.Select(x => x.ParameterName), comparer: StringComparer.CurrentCultureIgnoreCase);

foreach (var param in parameters.Values)
{
if (param.CameFromTemplate) continue;
Expand Down Expand Up @@ -250,7 +254,7 @@ protected void AddParameters(IDbCommand command, SqlMapper.Identity identity)
}
else
{
bool add = !command.Parameters.Contains(name);
bool add = !addedParameters.Contains(name);
IDbDataParameter p;
if (add)
{
Expand Down Expand Up @@ -296,6 +300,8 @@ protected void AddParameters(IDbCommand command, SqlMapper.Identity identity)
}
param.AttachedParam = p;
}

addedParameters.Add(name);
}

// note: most non-privileged implementations would use: this.ReplaceLiterals(command);
Expand Down