Prevent urllog announcing only the mimetype when it's guessable from the URL#9
Open
kythyria wants to merge 3 commits intoDarkDNA:masterfrom
Open
Prevent urllog announcing only the mimetype when it's guessable from the URL#9kythyria wants to merge 3 commits intoDarkDNA:masterfrom
kythyria wants to merge 3 commits intoDarkDNA:masterfrom
Conversation
… mimetype already guessable from the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt it was a bit more general to do it this way rather than blacklist i.imgur.com. Though this way still means a big list of mimetypes and extensions ends up being wanted (for now, just png/gif/jpeg/svg).