WIP: Overhaul the cvar system. Improve the robustness of virtual cvars #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l cvar_t's * cvar_hash_t is gone * Virtual cvars now use a linked list around their parent and have a pointer to their parent. * Cvars will now store their own hashindex to make deletions from the hashtable easier. Implemented Cvar_Delete where this is leveraged. Cvar_FindVarLink is eliminated also. Not needed anymore. * Implemented Cvar_DeleteVirtual and Cvar_DeleteVirtual_All to... delete virtual cvars. * Eliminated redundancy of Cvar_SetQuick_Internal by merging it with Cvar_SetQuick. * Misc cleanups
…rash when deleting vcvars
Contributor
|
Would need some more info about the "why". What exactly does this achieve? Any samples / console sessions that behave differently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.