Potential fix for code scanning alert no. 5: Cleartext transmission of sensitive information#8
Draft
DasIstMeow wants to merge 2 commits intomainfrom
Draft
Potential fix for code scanning alert no. 5: Cleartext transmission of sensitive information#8DasIstMeow wants to merge 2 commits intomainfrom
DasIstMeow wants to merge 2 commits intomainfrom
Conversation
…itive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…itive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/DasIstTobias/randombytes-mc-control/security/code-scanning/5
To fix the problem, we should ensure that certificate validation is not disabled when making HTTPS requests to external APIs. Specifically, remove or set
.danger_accept_invalid_certs(false)in thereqwest::Client::builder()configuration for both Mojang and Crafatar API calls in backend-frontend/src/main.rs. This guarantees that HTTPS encryption and certificate validation are properly enforced, protecting any transmitted information from interception. Only lines where areqwest::Clientis configured should be changed; no changes to request URLs or data flow are needed. No new dependencies are required, and existing code functionality is preserved.Suggested fixes powered by Copilot Autofix. Review carefully before merging.