Skip to content

Conversation

@Dashron
Copy link
Owner

@Dashron Dashron commented Jun 15, 2025

query typing should have been string | undefined, not string | number

@Dashron Dashron requested a review from Copilot June 15, 2025 20:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the query typing to allow undefined values, bumps version numbers for a new alpha release, and aligns example code with the updated router signature and build process.

  • Change query parsing generic to permit string | undefined
  • Bump package versions in root and example projects
  • Update example route handler signature and build script

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

File Description
src/middleware/router.ts Update parse generic to `string
package.json Bump version to 8.0.0-alpha.8
example/ts/src/routes/applyPrivateRoutes.ts Add method parameter to route handler signature
example/ts/package.json Bump version to 8.0.0-alpha.8 and prepend tsc before esbuild
Files not reviewed (1)
  • example/ts/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

src/middleware/router.ts:29

  • The args property still uses string | number but should match the new parse return type and use string | undefined instead.
args?: Record<string, string | number>

@Dashron Dashron merged commit 699fce6 into main Jun 15, 2025
10 checks passed
@Dashron Dashron deleted the fix/queryTyping branch August 27, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants