Skip to content

Race condition in ParallelForEachAsync when exceptions are thrown #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Race condition in ParallelForEachAsync when exceptions are thrown #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e58062
Not resetting exception list to null in ReadExceptions, so that in ca…
danylofitel Apr 21, 2020
4becfd4
Fixing the happy path
danylofitel Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Extensions/ParallelForEachExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;

Expand Down Expand Up @@ -76,11 +77,12 @@ public List<Exception> ReadExceptions()
_exceptionListLock.Enter(ref lockTaken);
try
{
return _exceptionList;
// Return a copy, so the list being returned will not be modified
// by tasks that are still running if the loop was canceled
return new List<Exception>(_exceptionList ?? Enumerable.Empty<Exception>());
}
finally
{
_exceptionList = null;
_exceptionListLock.Exit(useMemoryBarrier: false);
}
}
Expand Down