[PF-1096] Split client log files by date #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhuyoyo
reviewed
Dec 14, 2021
|
|
||
| private static final long MAX_FILE_SIZE = 5 * FileSize.MB_COEFFICIENT; // 5 MB | ||
| private static final int MAX_NUM_FILES = 5; | ||
| private static final long MAX_PER_FILE_SIZE = 10 * FileSize.MB_COEFFICIENT; |
Contributor
There was a problem hiding this comment.
just to clarify, is the per file size doubled after the change? cuz the PR description says it's the same.
yuhuyoyo
approved these changes
Dec 14, 2021
zloery
approved these changes
Dec 14, 2021
Contributor
zloery
left a comment
zloery
left a comment
There was a problem hiding this comment.
LGTM, pending Yu's question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small quality-of-life improvement for client debugging, this change causes the CLI to create log files with a date-specific pattern. We retain the same per-file and total history filesize limit, as well as a new limit on the total # of archive files to retain.
Before:
After: