-
Notifications
You must be signed in to change notification settings - Fork 4
[PF-1854] Alert user when there is no terra sshkey as they add a git repo reference #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/main/java/bio/terra/cli/serialization/userfacing/resource/UFDataCollection.java
melissachang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
| + "You must associate the new SSH public key with your GitHub account using " | ||
| + "https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent. " | ||
| + "Are you sure you want to proceed (y/N)?", | ||
| + "https://github.com/settings/keys. Are you sure you want to proceed (y/N)?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change? I followed https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent when I set up my key
For me, it was helpful that cli printed https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought it's more straightforward to just go to https://github.com/settings/keys to add your key? step 1 and 2 should be automatically covered by the notebook startup script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, is adding a key to https://github.com/settings/keys the same as ssh-add -K ~/.ssh/id_ed25519 ? If so, SG, thanks
| throw new UserActionableException( | ||
| "You do not have a Terra ssh key, cloning the git repo in the GCP notebook will" | ||
| + " fail. Please run `terra user ssh-key generate` and store the output (public key) in" | ||
| + " your GitHub account https://github.com/settings/keys."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @DisplayName("list and describe reflect adding a new referenced git repo") | ||
| void listDescribeReflectAdd() throws IOException { | ||
| workspaceCreator.login(); | ||
| TestCommand.runCommandExpectSuccess("user", "ssh-key", "generate", "--quiet"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Generate ssh key to avoid prompt about ssh key
example user flow: