Merged
Conversation
Parser complete! Converts token stream into YamlValue structures. Implementation: - parse() - entry point, handles empty documents - parse_value() - dispatcher (detects mapping/sequence/scalar) - parse_mapping() - collects key:value pairs - parse_sequence() - collects list items - parse_scalar() - converts tokens to YamlValue Features: - Recursive descent parsing - INDENT/DEDENT token handling for nesting - Support for inline and indented values - Proper ownership transfer (using ^ operator) - Type-safe scalar conversion (int, float, bool, string, null) YamlValue enhancements: - Added static factory methods (null(), bool(), integer(), float(), string(), sequence(), mapping()) - Fixed ownership semantics for collections - as_mapping() now returns a copy to avoid ownership issues Testing: - 10 new parser tests covering: - Empty input - All scalar types - Simple mappings - Multiple key-value pairs - Simple sequences - Total: 84 tests passing (74 lexer + 10 parser) Next: Phase 4 - Nested structures, public API, and examples Co-Authored-By: Warp <agent@warp.dev>
|
Review changes with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3: Parser implementation - recursive descent parser that converts tokens to YamlValue structures. Added 10 parser tests. Total: 84 tests passing.