[ABLD-18] Update macOS installation script for AArch64/ARM64

[rdesgroppes]

What does this PR do?

The present change adapts the macOS installation script to the foreseeable future, by considering the optional presence of an architecture qualifier in the DMG name.

Motivation

The script doesn't need to wait for AArch64/ARM64 DMGs to be publicly released - quite the other way around as we're going to add an architecture qualifier to DMGs, see: DataDog/omnibus-ruby#240.

Describe how you validated your changes

In the absence of automated tests, full credit go to @alopezz:

Possible Drawbacks / Trade-offs

When looking for an architecture-specific DMG, the script sends a HEAD request and simply checks against a HTTP 200 response status (happy path). This means that not only HTTP 404 but also HTTP 50x as well as curl errors will lead to falling back to the "universal" flavor. This is pretty conservative for the time being and might be reconsidered later.

Additional Notes

See also #16147, #18173.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: be223543-bee4-46d0-84ac-b0c8245fd51f

Baseline: bae87f6
Comparison: 20dc753
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+7.00	[+3.81, +10.19]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+7.00	[+3.81, +10.19]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.51	[+0.65, +2.36]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.54	[+0.47, +0.61]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.43	[-2.32, +3.17]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.42	[+0.30, +0.54]	1	Logs
➖	quality_gate_idle	memory utilization	+0.34	[+0.30, +0.38]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.31	[+0.27, +0.35]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.25	[+0.11, +0.39]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.20	[+0.13, +0.27]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	+0.16	[+0.11, +0.20]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.09	[-0.48, +0.65]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.61, +0.67]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.00	[-0.64, +0.64]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.28, +0.27]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.03, +0.02]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.63, +0.62]	1	Logs
➖	ddot_logs	memory utilization	-0.06	[-0.15, +0.04]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.06	[-0.12, -0.01]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.07	[-0.19, +0.05]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor bae87f6

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${702.99}$$ < $${703.45}$$	$${+0.04}$$	$${177.54}$$ < $${178.35}$$
✅	agent_deb_amd64_fips	$${-0}$$	$${701.23}$$ < $${701.7}$$	$${+0.01}$$	$${176.93}$$ < $${177.76}$$
✅	agent_heroku_amd64	$${0}$$	$${354.36}$$ < $${355.37}$$	$${-0}$$	$${94.75}$$ < $${95.72}$$
✅	agent_msi	$${0}$$	$${977.13}$$ < $${978.18}$$	$${0}$$	$${148.45}$$ < $${149.26}$$
✅	agent_rpm_amd64	$${-0}$$	$${702.98}$$ < $${703.44}$$	$${+0.03}$$	$${179.04}$$ < $${179.87}$$
✅	agent_rpm_amd64_fips	$${-0}$$	$${701.22}$$ < $${701.69}$$	$${-0.01}$$	$${178.66}$$ < $${179.47}$$
✅	agent_rpm_arm64	$${+0}$$	$${692.94}$$ < $${693.48}$$	$${+0.02}$$	$${162.73}$$ < $${163.62}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${691.24}$$ < $${691.79}$$	$${+0.03}$$	$${161.84}$$ < $${162.65}$$
✅	agent_suse_amd64	$${-0}$$	$${702.98}$$ < $${703.44}$$	$${+0.03}$$	$${179.04}$$ < $${179.87}$$
✅	agent_suse_amd64_fips	$${-0}$$	$${701.22}$$ < $${701.69}$$	$${-0.01}$$	$${178.66}$$ < $${179.47}$$
✅	agent_suse_arm64	$${+0}$$	$${692.94}$$ < $${693.48}$$	$${+0.02}$$	$${162.73}$$ < $${163.62}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${691.24}$$ < $${691.79}$$	$${+0.03}$$	$${161.84}$$ < $${162.65}$$
✅	docker_agent_amd64	$${-0}$$	$${786.79}$$ < $${787.26}$$	$${-0}$$	$${270.76}$$ < $${271.51}$$
✅	docker_agent_arm64	$${+0}$$	$${800.26}$$ < $${800.74}$$	$${-0}$$	$${258.42}$$ < $${259.24}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${977.98}$$ < $${978.45}$$	$${+0}$$	$${339.72}$$ < $${340.47}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${980.05}$$ < $${980.54}$$	$${+0.01}$$	$${323.39}$$ < $${324.2}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${213.7}$$ < $${214.5}$$	$${-0}$$	$${72.64}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${229.56}$$ < $${230.33}$$	$${-0}$$	$${68.89}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${39.19}$$ < $${39.57}$$	$${-0}$$	$${15.11}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0}$$	$${37.86}$$ < $${38.2}$$	$${-0}$$	$${14.53}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.43}$$ < $${31.4}$$	$${+0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.99}$$ < $${29.97}$$	$${+0}$$	$${6.94}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.43}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.43}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${53.87}$$ < $${54.55}$$	$${-0}$$	$${13.57}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.2}$$ < $${51.9}$$	$${+0}$$	$${11.74}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${50.71}$$ < $${51.42}$$	$${+0.03}$$	$${11.85}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${53.87}$$ < $${54.55}$$	$${-0}$$	$${13.59}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${51.21}$$ < $${51.91}$$	$${+0}$$	$${11.76}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${0}$$	$${53.87}$$ < $${54.55}$$	$${-0}$$	$${13.59}$$ < $${14.47}$$

[rdesgroppes]

Notes to reviewers:

1. DRY: leveraging existing dmg_base_url defined somewhere above (and set to https://s3.amazonaws.com/dd-agent)
2. grep -E: so as to avoid escaping parenthesis in the regexp (-E is portable, contrarily to -P)
3. (.$arch)?: retained DMGs will be either "universal" (well, let's call it that way) or match the current $arch (important is to discard other archs)

[rdesgroppes]

Note to reviewers: moved from somewhere above because determining dmg_url (now dmg_url_prefix) was too distant from its usage.

[rdesgroppes]

Note to reviewers: snippet moved from somewhere above so that it's executed only when applicable.
In particular, if $arch is arm64 and the retained DMG is also arm64, there's no point to prompt for Rosetta 2 installation.

[alopezz]

LGTM (just remember to remove the changelog entry before merging).

[alopezz]

As these are distributed separately from the channel, and are therefore not tied to Agent releases, I think we should skip the changelog entry in this case.

[rdesgroppes]

✔️ Done removing changelog entry.