Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Aug 7, 2025

What does this PR do?

Pass a more canonical1 target to swiftc for AArch64/ARM64 on macOS:

-swiftc ... -target arm64-apple-macosx11.0 ...
+swiftc ... -target arm64-apple-macos11.0 ...

Motivation

See:

Describe how you validated your changes

Successful build.

Additional Notes

Footnotes

  1. preferred, if not recommended

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-build labels Aug 7, 2025
@rdesgroppes rdesgroppes added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Aug 7, 2025
@rdesgroppes rdesgroppes changed the title Use more canonical macOS AArch64/ARM64 target Pass canonical target to swiftc on AArch64/ARM64 Aug 7, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/use-more-canonical-macos-aarch64-target branch from 2801c3b to f9369d2 Compare August 7, 2025 19:17
@rdesgroppes rdesgroppes added the ask-review Ask required teams to review this PR label Aug 7, 2025
@rdesgroppes rdesgroppes marked this pull request as ready for review August 7, 2025 19:17
@rdesgroppes rdesgroppes requested a review from a team as a code owner August 7, 2025 19:18
@rdesgroppes rdesgroppes added ask-review Ask required teams to review this PR and removed ask-review Ask required teams to review this PR labels Aug 7, 2025
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 7, 2025

View all feedbacks in Devflow UI.

2025-08-07 19:22:38 UTC ℹ️ Start processing command /merge


2025-08-07 19:22:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-07 23:23:02 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Aug 7, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ed98c547-77cc-4e38-b1a9-ae618c2c7f28

Baseline: 666416e
Comparison: 10e0373
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.54 [+0.36, +6.73] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.54 [+0.36, +6.73] 1 Logs
quality_gate_logs % cpu utilization +0.74 [-2.08, +3.55] 1 Logs bounds checks dashboard
file_tree memory utilization +0.29 [+0.25, +0.33] 1 Logs
quality_gate_idle_all_features memory utilization +0.11 [+0.08, +0.14] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.05 [-0.04, +0.14] 1 Logs
ddot_metrics memory utilization +0.03 [-0.09, +0.15] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.53, +0.59] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.59, +0.64] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.60, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.34, +0.31] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.62, +0.51] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.16 [-0.20, -0.13] 1 Logs
otlp_ingest_logs memory utilization -0.17 [-0.30, -0.05] 1 Logs
quality_gate_metrics_logs memory utilization -0.24 [-0.63, +0.15] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.40 [-0.55, -0.26] 1 Logs
quality_gate_idle memory utilization -0.49 [-0.53, -0.46] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.75 [-0.87, -0.63] 1 Logs
docker_containers_memory memory utilization -0.90 [-0.95, -0.86] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 7, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 666416e

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${701.33}$$ < $${704.84}$$ $${+0.03}$$ $${177.66}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${699.59}$$ < $${703.09}$$ $${-0.01}$$ $${176.95}$$ < $${178.12}$$
agent_heroku_amd64 $${-0}$$ $${351.02}$$ < $${355.37}$$ $${-0}$$ $${94.65}$$ < $${95.72}$$
agent_msi $${0}$$ $${975.33}$$ < $${980.61}$$ $${+0.01}$$ $${147.43}$$ < $${149.31}$$
agent_rpm_amd64 $${-0}$$ $${701.32}$$ < $${704.83}$$ $${-0.04}$$ $${179.82}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${699.58}$$ < $${703.08}$$ $${+0.01}$$ $${178.83}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${690.25}$$ < $${694.74}$$ $${+0.02}$$ $${162.11}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${688.56}$$ < $${693.05}$$ $${+0.03}$$ $${161.12}$$ < $${163.0}$$
agent_suse_amd64 $${-0}$$ $${701.32}$$ < $${704.83}$$ $${-0.04}$$ $${179.82}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${699.58}$$ < $${703.08}$$ $${+0.01}$$ $${178.83}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${690.25}$$ < $${694.74}$$ $${+0.02}$$ $${162.11}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${688.56}$$ < $${693.05}$$ $${+0.03}$$ $${161.12}$$ < $${163.0}$$
docker_agent_amd64 $${-0}$$ $${783.32}$$ < $${788.65}$$ $${+0.01}$$ $${269.98}$$ < $${272.01}$$
docker_agent_arm64 $${+0}$$ $${795.58}$$ < $${802.0}$$ $${+0.01}$$ $${256.75}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${-0}$$ $${974.62}$$ < $${979.84}$$ $${+0}$$ $${339.01}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${-0}$$ $${975.48}$$ < $${981.8}$$ $${+0.01}$$ $${321.77}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${-0}$$ $${214.44}$$ < $${214.5}$$ $${+0}$$ $${72.91}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${-0}$$ $${230.26}$$ < $${230.33}$$ $${-0}$$ $${69.14}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.72}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.42}$$ < $${38.2}$$ $${-0}$$ $${14.39}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.95}$$ < $${31.4}$$ $${-0}$$ $${7.89}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.54}$$ < $${29.97}$$ $${-0}$$ $${6.85}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.95}$$ < $${31.4}$$ $${+0}$$ $${7.9}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.95}$$ < $${31.4}$$ $${+0}$$ $${7.9}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${-0}$$ $${13.68}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.65}$$ < $${51.9}$$ $${+0}$$ $${11.85}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.18}$$ < $${51.42}$$ $${+0}$$ $${11.91}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${+0}$$ $${13.7}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.18}$$ < $${51.91}$$ $${+0}$$ $${11.93}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${+0}$$ $${13.7}$$ < $${14.47}$$

@rdesgroppes rdesgroppes added this to the 7.70.0 milestone Aug 8, 2025
See:
- https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary#Update-the-Architecture-List-of-Custom-Makefiles
- #18173 (comment)
- https://stackoverflow.com/a/73773711:
> **Is there a generic -target I can use that will work for all macOS
> versions (maybe even future versions)?**
>
> Yes. For example, if you are targeting macos 11, you can use
> `-target x86_64-apple-macos11.0` for intel CPUs and
> `arm64-apple-macos11.0` for apple silicon CPUs. By default, targeting
> macos 11 means you can run the binary in future macos version.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/use-more-canonical-macos-aarch64-target branch from f9369d2 to 10e0373 Compare August 8, 2025 06:42
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 8, 2025

View all feedbacks in Devflow UI.

2025-08-08 06:43:03 UTC ℹ️ Start processing command /merge


2025-08-08 06:43:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-08 07:35:20 UTC ⚠️ MergeQueue: This merge request was unqueued

regis.desgroppes@datadoghq.com unqueued this merge request

@rdesgroppes
Copy link
Contributor Author

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 8, 2025

View all feedbacks in Devflow UI.

2025-08-08 07:35:16 UTC ℹ️ Start processing command /remove


2025-08-08 07:35:19 UTC ℹ️ Devflow: /remove

@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 8, 2025

View all feedbacks in Devflow UI.

2025-08-08 08:21:02 UTC ℹ️ Start processing command /merge


2025-08-08 08:21:11 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-08 09:44:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 34m (p90).


2025-08-08 09:59:53 UTC ℹ️ MergeQueue: This merge request was merged

@rdesgroppes rdesgroppes added the backport/7.70.x Automatically create a backport PR to 7.70.x label Aug 8, 2025
@dd-mergequeue dd-mergequeue bot merged commit f92d577 into main Aug 8, 2025
348 checks passed
@dd-mergequeue dd-mergequeue bot deleted the regis.desgroppes/use-more-canonical-macos-aarch64-target branch August 8, 2025 09:59
@github-actions github-actions bot removed this from the 7.70.0 milestone Aug 8, 2025
@github-actions github-actions bot added this to the 7.71.0 milestone Aug 8, 2025
@rdesgroppes rdesgroppes modified the milestones: 7.71.0, 7.70.0 Aug 8, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request Aug 8, 2025
@rdesgroppes rdesgroppes changed the title Pass canonical target to swiftc on AArch64/ARM64 Pass canonical target to swiftc on AArch64/ARM64 (ABLD-28 follow-up) Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR backport/7.70.x Automatically create a backport PR to 7.70.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants