[MVP] feat(Autodiscovery): CRD-driven check scheduling via DatadogInstrumentation#47654
[MVP] feat(Autodiscovery): CRD-driven check scheduling via DatadogInstrumentation#47654Mathew-Estafanous wants to merge 16 commits intomainfrom
Conversation
Go Package Import DifferencesBaseline: 3002045
|
Files inventory check summaryFile checks results against ancestor 30020450: Results for datadog-agent_7.78.0~devel.git.548.0a7b81e.pipeline.102404105-1_amd64.deb:No change detected |
140fc01 to
0f56792
Compare
7041fd4 to
ab81a3c
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
6 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3002045 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.22 | [-1.78, +4.22] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.22 | [-1.78, +4.22] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.71 | [+0.47, +0.94] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.52 | [+0.43, +0.61] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.45 | [+0.23, +0.68] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.30 | [+0.24, +0.36] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.22 | [+0.06, +0.39] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.10 | [+0.05, +0.15] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.06 | [-0.08, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.08, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.42, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.16, +0.19] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.09, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.49, +0.50] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.20, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.43, +0.33] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.10 | [-1.73, +1.53] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | -0.14 | [-0.32, +0.03] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.16 | [-0.21, -0.10] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.18 | [-0.26, -0.10] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.22 | [-0.39, -0.06] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.33 | [-0.38, -0.27] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.40 | [-0.44, -0.36] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -2.06 | [-2.19, -1.93] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 708 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 273.56MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 596 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.92MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 487.21MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 203.56MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 346.59 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 409.08MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
What does this PR do?
Adds end-to-end CRD-driven check scheduling: the Cluster Agent watches
DatadogInstrumentationCRs, converts theirspec.config.checksinto autodiscovery-compatible YAML, writes the result to a ConfigMap, and the Node Agent picks it up via a new file-based config provider.Two independent pieces work together:
Cluster Agent —
InstrumentationController(pkg/clusteragent/instrumentation/): A shared informer watchesdatadoginstrumentationsCRDs. On each reconciliation cycle it converts all CRs, then fans out to registeredConfigSectionHandlerimplementations. Today the only handler ischecks.Handler, which builds AD configs (with CEL selectors derived fromspec.selector) and writes them to a single ConfigMap. The controller is leader-aware and idempotent.Node Agent —
CRDFileConfigProvider(comp/core/autodiscovery/providers/crd_file.go): Reads YAML files from a directory (autoconf_crd_checks_dir, default/etc/datadog-agent/crd-conf.d) that is expected to be a ConfigMap volume mount. Files follow the naming convention<namespace>_<crname>_<checkname>.yaml. The provider is registered whenpodcheck.enabledis true.The controller architecture is deliberately extensible. Adding a new config section (e.g., APM instrumentation) requires only implementing
ConfigSectionHandlerand adding it to the handler slice — no changes to the shared controller.New config keys
workload_config.enabledtrueautoconf_crd_checks_dir/etc/datadog-agent/crd-conf.dautoconf_crd_checks_poll_interval10(seconds)Motivation
Today, scheduling an AD check on a set of pods requires either Kubernetes annotations on the workload or static config files baked into the Agent image. Both approaches couple check configuration to the workload owner and don't scale well when a platform team wants to roll out checks across many workloads centrally.
DatadogInstrumentation(defined in datadog-operator PR #2724) lets a platform team declare checks as Kubernetes CRs, scoped to pods via label/annotation selectors. The Cluster Agent reconciles these CRs into a ConfigMap that is mounted into the Node Agent, closing the loop without any changes to workloads.The generalized controller design prepares the path for future CRD-driven features to plug in alongside checks.
Describe how you validated your changes
go test -tags kubeapiserver ./pkg/clusteragent/instrumentation/...):comp/core/autodiscovery/providers/crd_file_test.go):**TODO: manual validation against a local cluster
Additional Notes
DatadogInstrumentationCRD type comes from datadog-operator PR #2724. The operator dependency is pinned to the head of that PR branch (56ca338). This will need updating to a release tag before merge.workloadfilter.CreatePodhelper was extended to accept labels (previously only annotations), since CEL selectors now match on pod labels.