[SYNTH-23730] Fix plugin import on Windows #2033
Merged
+142
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Closes #2025
This PR fixes an
ERR_UNSUPPORTED_ESM_URL_SCHEMEerror on Windows when importing plugins (be it built-in or not):How?
url.pathToFileURL(absolutePath)withawait import()While we could replace
await import()withrequire(), it's better to avoid usingrequire()when possible to ease any future migration to ESM-only (although not planned yet).Review checklist