[sourcemaps] sourceMappingURL support #2035
Merged
+141
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/gh-issue-1997
branch
from
46ba529 to
313f7ea
Compare
buranmert
added
the
rum
buranmert
force-pushed
the
buranmert/gh-issue-1997
branch
from
313f7ea to
d0b20bf
Compare
Miz85
approved these changes
Jan 6, 2026
Miz85
left a comment
Miz85
left a comment
There was a problem hiding this comment.
LGTM, I have a couple of minor comments but all in all it's okay. It would be good to test it on a real app before merging.
Contributor
Author
|
while testing with a simple Next JS project I found that some my manual testing passed ✅ |
Drarig29
reviewed
Jan 7, 2026
buranmert
force-pushed
the
buranmert/gh-issue-1997
branch
from
e65b3e3 to
54af34f
Compare
Drarig29
reviewed
Jan 7, 2026
Contributor
Drarig29
left a comment
Drarig29
left a comment
There was a problem hiding this comment.
Let's use the async FS API to unblock the event loop
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 0899aa7 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
buranmert
force-pushed
the
buranmert/gh-issue-1997
branch
from
61fa864 to
0899aa7
Compare
Drarig29
approved these changes
Jan 8, 2026
Contributor
Drarig29
left a comment
Drarig29
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes!
Contributor
Author
|
this PR should close #1997 |
This was referenced Jan 8, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
sourcemaps uploadnow looks at the last non-empty lines of minified JS files in the given directory and reads theirsourceMappingURLvalues in order to find their corresponding sourcemap files.Before this mapping logic was hardcoded as the following:
foo.min.js->foo.map.jsHow?
A brief description of implementation details of this PR.
Review checklist