[SVLS-8267] fix error on unspecified runtime #2047
Merged
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
approved these changes
Jan 7, 2026
ava-silver
added
bug
TalUsvyatsky
reviewed
Jan 7, 2026
|
|
||
| if (runtimeType === RuntimeType.CUSTOM) { | ||
| if (settings.layerVersion !== 'none') { | ||
| if (typeof settings.layerVersion === 'number') { |
Contributor
There was a problem hiding this comment.
is it possible to add a test for this?
TalUsvyatsky
approved these changes
Jan 7, 2026
ava-silver
deleted the
ava.silver/svls-8267/fix-error-on-unspecified-runtime
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes an error where the default arguments error for custom runtime functions. Now, we check for a specified layer number rather than specifically "none" so the default value or "none" or "latest" don't error.
How?
A brief description of implementation details of this PR.
Review checklist