Merged
Conversation
joeyzhao2018
reviewed
Dec 5, 2025
Contributor
joeyzhao2018
left a comment
There was a problem hiding this comment.
- Based on aws doc, not all commercial regions support ssm-fips endpoint.
- When the configuration explicitly enabled FIPS mode but the endpoint is not supported, a warning log is needed IMHO.
litianningdatadog
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Overrides the SSM url to be
ssm-fips.{REGION}.amazonaws.comonly in commercial FIPS mode. Gov endpoints should use the defaultssm.{REGION}.amazonaws.com. https://docs.aws.amazon.com/general/latest/gr/ssm.htmlMotivation
Customer reported Datadog Forwarder getting API key from SSM in gov region is not working SLES-2580
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply