Conversation
b2401a9 to
56ee1e8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
+ Coverage 38.94% 39.00% +0.05%
==========================================
Files 313 313
Lines 27134 27167 +33
==========================================
+ Hits 10567 10596 +29
- Misses 15778 15780 +2
- Partials 789 791 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
56ee1e8 to
1bd0750
Compare
1bd0750 to
94b4da5
Compare
94b4da5 to
98f90bb
Compare
b2a8245 to
e1688ef
Compare
e1688ef to
5155320
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 515532045d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
internal/controller/datadogagent/feature/servicediscovery/feature.go
Outdated
Show resolved
Hide resolved
domalessi
left a comment
There was a problem hiding this comment.
Left a suggestion to improve clarity! Approving so you're not blocked on me.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
|
||
| // hasOtherSystemProbeFeatures returns true if any feature besides service discovery | ||
| // requires the full system-probe binary. When true, system-probe-lite cannot be used. | ||
| func hasOtherSystemProbeFeatures(features *v2alpha1.DatadogFeatures) bool { |
There was a problem hiding this comment.
How can we ensure that list is correct and complete and remains that way? It's not obvious that I have to patch feature/servicediscovery/feature.go if I'm adding some unrelated feature that uses system-probe, and that a failure to do so may cause my feature to not work in some cases.
What does this PR do?
Adds support for starting system-probe-lite (SPL) instead of the full system-probe in the operator when only discovery is enabled.
SPL is a privileged Rust binary that implements just the discovery module. Kubernetes needs a different approach than Docker/Linux since the operator is updated asynchronously to agent versions — we can't enable discovery by default and guarantee we won't start the full system-probe with default config.
How it works:
Motivation
Match agent configuration.
Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
However, like in the Helm chart change, it checks first for the
sd-agentbinary to exists in the container image. This means using an older agent image will simply usesystem-probe's discovery implementation instead of sd-agent.Describe your test plan
features.serviceDiscovery.enabledset to false: no system-probe container.features.serviceDiscovery.enabledset to true:system-probecontainer starts; execssystem-probe-lite.features.npm.enabled):system-probecontainer starts;system-proberuns directly.system-probecontainer starts;system-proberuns directly.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel