[CONS-8186] Implement DD_SLO_FORCE_SYNC_PERIOD for DatadogSLO#2811
[CONS-8186] Implement DD_SLO_FORCE_SYNC_PERIOD for DatadogSLO#2811mrdoggopat wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22a31dce60
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 38.77% 38.92% +0.14%
==========================================
Files 311 311
Lines 27029 27200 +171
==========================================
+ Hits 10481 10588 +107
- Misses 15766 15822 +56
- Partials 782 790 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/merge |
|
View all feedbacks in Devflow UI.
You are not allowed to use the merge queue towards |
What does this PR do?
This PR adds an option for users to configure the DatadogSLO force sync period. This option is available for DatadogMonitor and DatadogDashboard so it would be nice to have this for DatadogSLO.
Motivation
CONS-8186. Mainly to control the re-sync period to avoid potential rate limit issues.
Describe your test plan
examples/datadogslo/k get datadogslo <datadog slo name> -o yaml | yq .status.lastForceSyncTimeensure it's less than 2mins old{"level":"DEBUG","ts":"2026-03-24T14:31:51.776Z","logger":"controllers.DatadogSLO","msg":"Setting SLO force sync period","datadogslo":{"name":"example-slo-monitor3","namespace":"default"},"minutes":2}Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel