[datadog-operator] Update Github Workflow for Milestone#2837
Draft
[datadog-operator] Update Github Workflow for Milestone#2837
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=======================================
Coverage 38.94% 38.94%
=======================================
Files 313 313
Lines 27139 27139
=======================================
Hits 10570 10570
Misses 15780 15780
Partials 789 789
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the Github Workflows surrounding PR Milestones.
Decouples the
qa/skip-qalabel from theMilestone. Targeting a particular release should be independent of whether or not QA is required. By default, QA remains automatically required and only familiar Operator users will add the label to skip QA.Every PR will have a milestone associated to it determine on the base branch that it merged onto to. (Merge onto main gets latest Milestone, Merge onto rc branch gets the rc milestone). This mirrors the datadog-agent milestone workflow which adds a milestone post merge.
Describe your test plan
The
add-milestoneaction was mostly copied from the Agent. The main difference is how we're querying for the milestone itself. The Agent stores the active milestone explicitly within a file in the code base. Theoretically we could do the same by looking atconfig/manager/kustomization.yamlfor thenewTagfield. However, @claude decided to instead directly query the open milestones within the repo and pick the latest when merging onto main. Testing the commands locally seem good:Getting the Milestone when merging onto main:
Getting the Milestone when not merging onto main:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependencies