Skip to content

Conversation

@ambushwork
Copy link
Member

What does this PR do?

  • Update the telemetry message and properties to align with IOS
  • Fix the issue when profiler callback is called before internalLogger is set, the telemetry was not sent.
  • Update the sampling frequency from 100hz to 101hz to avoid lockstep sampling.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
Copy link
Member Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5241f0c3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ambushwork ambushwork force-pushed the yl/profiling/telemetry branch from a5241f0 to a4337d0 Compare January 20, 2026 13:06
@ambushwork
Copy link
Member Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4337d0000

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ambushwork ambushwork force-pushed the yl/profiling/telemetry branch from a4337d0 to 5754e42 Compare January 20, 2026 13:36
@datadog-official
Copy link

datadog-official bot commented Jan 20, 2026

🎯 Code Coverage
Patch Coverage: 80.85%
Overall Coverage: 65.97% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: efe732b | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.86%. Comparing base (0d7396f) to head (efe732b).
⚠️ Report is 2 commits behind head on feature/perfetto-profiling.

Files with missing lines Patch % Lines
...id/profiling/internal/perfetto/PerfettoProfiler.kt 89.19% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #3134      +/-   ##
==============================================================
+ Coverage                       70.81%   70.86%   +0.05%     
==============================================================
  Files                             906      906              
  Lines                           33359    33378      +19     
  Branches                         5590     5593       +3     
==============================================================
+ Hits                            23623    23652      +29     
+ Misses                           8171     8161      -10     
  Partials                         1565     1565              
Files with missing lines Coverage Δ
...id/profiling/internal/perfetto/PerfettoProfiler.kt 92.68% <89.19%> (+0.62%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork marked this pull request as ready for review January 20, 2026 14:33
@ambushwork ambushwork requested a review from a team as a code owner January 20, 2026 14:33
0xnm
0xnm previously approved these changes Jan 20, 2026
@ambushwork ambushwork merged commit ebf4fcb into feature/perfetto-profiling Jan 20, 2026
26 checks passed
@ambushwork ambushwork deleted the yl/profiling/telemetry branch January 20, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants