-
Notifications
You must be signed in to change notification settings - Fork 74
Update Profiling App launch telemetry #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5241f0c3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt
Show resolved
Hide resolved
a5241f0 to
a4337d0
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4337d0000
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt
Show resolved
Hide resolved
a4337d0 to
5754e42
Compare
|
🎯 Code Coverage 🔗 Commit SHA: efe732b | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #3134 +/- ##
==============================================================
+ Coverage 70.81% 70.86% +0.05%
==============================================================
Files 906 906
Lines 33359 33378 +19
Branches 5590 5593 +3
==============================================================
+ Hits 23623 23652 +29
+ Misses 8171 8161 -10
Partials 1565 1565
🚀 New features to boost your workflow:
|
...-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt
Show resolved
Hide resolved
...-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt
Show resolved
Hide resolved
5754e42 to
efe732b
Compare
What does this PR do?
internalLoggeris set, the telemetry was not sent.Review checklist (to be filled by reviewers)