RUM-13568: [Cronet]: Supporting RUM <> APM integration for Cronet #3136
Conversation
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ee7daf6e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| override fun addHeader(header: String, value: String?): UrlRequest.Builder = apply { | ||
| headers[header] = listOfNotNull(value) | ||
| delegate.addHeader(header, value) | ||
| val currentValues = headers[header]?.toMutableList() ?: mutableListOf() | ||
| if (value != null) { | ||
| currentValues.add(value) | ||
| } | ||
| headers[header] = currentValues |
There was a problem hiding this comment.
DatadogUrlRequestBuilder.addHeader() now only updates the local headers map and never forwards to delegate.addHeader. Later, buildCronetRequest() calls addHeaders(headers), which invokes this same override again, so the delegate builder never receives any headers. This means every Cronet request built through DatadogCronetEngine will drop user-supplied headers and tracing headers, breaking authentication and trace propagation. Consider forwarding to delegate.addHeader (or ensuring addHeaders writes to the delegate) so the actual request carries the headers.
Useful? React with 👍 / 👎.
What does this PR do?
In this PR we are copying the main logic from
TracingInterceptor/DatadogInterceptorinto theNetworkTracingInstrumentationin order to:CronetMotivation
Continuing to add an integration for
Cronetlibrary meanwhile preparing infrastructure to migrateOkHttponto the same logic.Additional Notes
Note that in this PR we are not supporting deep network instrumentation that is being done by
TracingInterceptorinOkHttp. This logic will be supported in a further PR as this one is already pretty big.NOTE: In this PR as an experiment an AI agent helped to write tests and some docs. I've made few iterations of a fixes for that but if you spot any issues - let me know. AI wasn't involved into production code development.
Review checklist (to be filled by reviewers)