RUM-13469: Add totalRam and logicalCpuCount to DeviceInfo
#2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
2 times, most recently
from
b619739 to
cfa29d7
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
from
cfa29d7 to
d7c19e0
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
4 times, most recently
from
46dd08f to
5642bd8
Compare
simaoseica-dd
previously approved these changes
Nov 28, 2025
Contributor
simaoseica-dd
left a comment
simaoseica-dd
left a comment
There was a problem hiding this comment.
LGTM!
Just left a suggestion for improvement.
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
3 times, most recently
from
b9ca352 to
200e6ea
Compare
maxep
requested changes
Dec 2, 2025
Member
maxep
left a comment
maxep
left a comment
There was a problem hiding this comment.
Looks great 👍 Just a little change to make!
Comment on lines
159
to
160
| processorCount: Double(ProcessInfo.processInfo.processorCount), | ||
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) |
Member
There was a problem hiding this comment.
cr/ Lets use the processInfo provided as argument:
Suggested change
| processorCount: Double(ProcessInfo.processInfo.processorCount), | |
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) | |
| processorCount: Double(processInfo.processorCount), | |
| totalRam: Double(processInfo.physicalMemory / (1_024 * 1_024)) |
Member
Author
There was a problem hiding this comment.
Good catch 👍 thanks! I have rebased the PR and pushed the new changes
Comment on lines
214
to
215
| processorCount: Double(ProcessInfo.processInfo.processorCount), | ||
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) |
Member
There was a problem hiding this comment.
cr/ same here
Suggested change
| processorCount: Double(ProcessInfo.processInfo.processorCount), | |
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) | |
| processorCount: Double(processInfo.processorCount), | |
| totalRam: Double(processInfo.physicalMemory / (1_024 * 1_024)) |
Comment on lines
174
to
175
| processorCount: Double(ProcessInfo.processInfo.processorCount), | ||
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) |
Member
There was a problem hiding this comment.
Suggested change
| processorCount: Double(ProcessInfo.processInfo.processorCount), | |
| totalRam: Double(ProcessInfo.processInfo.physicalMemory / (1_024 * 1_024)) | |
| processorCount: Double(processInfo.processorCount), | |
| totalRam: Double(processInfo.physicalMemory / (1_024 * 1_024)) |
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
from
200e6ea to
af3aa56
Compare
marco-saia-datadog
changed the title
totalRam and processorCount to DeviceInfototalRam and processorCount to DeviceInfo
marco-saia-datadog
dismissed stale reviews from maxep and simaoseica-dd
via
3d4afbb
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12199/new-device-capability-metrics
branch
from
af3aa56 to
3d4afbb
Compare
marco-saia-datadog
changed the title
totalRam and processorCount to DeviceInfototalRam and logicalCpuCount to DeviceInfo
Member
Author
|
Following an internal discussion, I have renamed Here are the changes in |
simaoseica-dd
approved these changes
Jan 13, 2026
marco-saia-datadog
deleted the
marcosaia/RUM-12199/new-device-capability-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds new attributes to the Device Info:
These attributes allow us to classify devices as low-, mid-, or high-tier, which improves our ability to diagnose performance issues.
How?
logicalCpuCountis retrieved fromProcessInfo.processInfo.processorCount, which returns the number of processor cores available on the device (ref)totalRamis retrieved fromProcessInfo.processInfo.physicalMemory, which returns the amount of physical memory on the device in bytes (ref)Additional Notes
Review checklist
make api-surface)