-
Notifications
You must be signed in to change notification settings - Fork 315
Databricks support changes #9877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Databricks support changes #9877
Conversation
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039010
Total [baseline] (8.693 s) : 0, 8693285
Agent [candidate] (1.03 s) : 0, 1029911
Total [candidate] (8.66 s) : 0, 8659535
section iast
Agent [baseline] (1.171 s) : 0, 1170616
Total [baseline] (9.358 s) : 0, 9357936
Agent [candidate] (1.167 s) : 0, 1166661
Total [candidate] (9.374 s) : 0, 9374090
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (708.335 ms) : 0, 708335
BytebuddyAgent [candidate] (702.5 ms) : 0, 702500
GlobalTracer [baseline] (246.745 ms) : 0, 246745
GlobalTracer [candidate] (244.768 ms) : 0, 244768
AppSec [baseline] (32.898 ms) : 0, 32898
AppSec [candidate] (32.109 ms) : 0, 32109
Debugger [baseline] (6.55 ms) : 0, 6550
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (693.012 µs) : 0, 693
Remote Config [candidate] (678.354 µs) : 0, 678
Telemetry [baseline] (14.444 ms) : 0, 14444
Telemetry [candidate] (14.54 ms) : 0, 14540
Flare Poller [baseline] (6.624 ms) : 0, 6624
Flare Poller [candidate] (6.37 ms) : 0, 6370
section iast
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (831.394 ms) : 0, 831394
BytebuddyAgent [candidate] (828.231 ms) : 0, 828231
GlobalTracer [baseline] (235.104 ms) : 0, 235104
GlobalTracer [candidate] (234.766 ms) : 0, 234766
AppSec [baseline] (28.189 ms) : 0, 28189
AppSec [candidate] (27.247 ms) : 0, 27247
Debugger [baseline] (6.123 ms) : 0, 6123
Debugger [candidate] (6.112 ms) : 0, 6112
Remote Config [baseline] (613.256 µs) : 0, 613
Remote Config [candidate] (600.655 µs) : 0, 601
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (8.432 ms) : 0, 8432
Flare Poller [baseline] (4.118 ms) : 0, 4118
Flare Poller [candidate] (4.088 ms) : 0, 4088
IAST [baseline] (33.571 ms) : 0, 33571
IAST [candidate] (34.295 ms) : 0, 34295
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031782
Total [baseline] (10.911 s) : 0, 10911151
Agent [candidate] (1.031 s) : 0, 1031096
Total [candidate] (10.906 s) : 0, 10906194
section appsec
Agent [baseline] (1.203 s) : 0, 1203439
Total [baseline] (10.965 s) : 0, 10965118
Agent [candidate] (1.219 s) : 0, 1218501
Total [candidate] (11.11 s) : 0, 11109558
section iast
Agent [baseline] (1.159 s) : 0, 1159446
Total [baseline] (11.077 s) : 0, 11076868
Agent [candidate] (1.17 s) : 0, 1169505
Total [candidate] (11.141 s) : 0, 11140861
section profiling
Agent [baseline] (1.178 s) : 0, 1178199
Total [baseline] (10.919 s) : 0, 10918775
Agent [candidate] (1.176 s) : 0, 1176096
Total [candidate] (10.912 s) : 0, 10911614
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (703.622 ms) : 0, 703622
BytebuddyAgent [candidate] (703.043 ms) : 0, 703043
GlobalTracer [baseline] (245.062 ms) : 0, 245062
GlobalTracer [candidate] (245.191 ms) : 0, 245191
AppSec [baseline] (32.25 ms) : 0, 32250
AppSec [candidate] (32.431 ms) : 0, 32431
Debugger [baseline] (6.381 ms) : 0, 6381
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (678.926 µs) : 0, 679
Remote Config [candidate] (698.283 µs) : 0, 698
Telemetry [baseline] (15.288 ms) : 0, 15288
Telemetry [candidate] (14.308 ms) : 0, 14308
Flare Poller [baseline] (5.738 ms) : 0, 5738
Flare Poller [candidate] (6.438 ms) : 0, 6438
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (726.639 ms) : 0, 726639
BytebuddyAgent [candidate] (737.206 ms) : 0, 737206
GlobalTracer [baseline] (235.82 ms) : 0, 235820
GlobalTracer [candidate] (239.385 ms) : 0, 239385
AppSec [baseline] (174.481 ms) : 0, 174481
AppSec [candidate] (174.784 ms) : 0, 174784
Debugger [baseline] (5.872 ms) : 0, 5872
Debugger [candidate] (5.937 ms) : 0, 5937
Remote Config [baseline] (627.689 µs) : 0, 628
Remote Config [candidate] (633.25 µs) : 0, 633
Telemetry [baseline] (8.385 ms) : 0, 8385
Telemetry [candidate] (8.463 ms) : 0, 8463
Flare Poller [baseline] (3.877 ms) : 0, 3877
Flare Poller [candidate] (3.959 ms) : 0, 3959
IAST [baseline] (25.05 ms) : 0, 25050
IAST [candidate] (25.284 ms) : 0, 25284
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (822.456 ms) : 0, 822456
BytebuddyAgent [candidate] (831.542 ms) : 0, 831542
GlobalTracer [baseline] (233.528 ms) : 0, 233528
GlobalTracer [candidate] (234.854 ms) : 0, 234854
AppSec [baseline] (29.786 ms) : 0, 29786
AppSec [candidate] (27.654 ms) : 0, 27654
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (602.689 µs) : 0, 603
Remote Config [candidate] (600.727 µs) : 0, 601
Telemetry [baseline] (8.437 ms) : 0, 8437
Telemetry [candidate] (8.452 ms) : 0, 8452
Flare Poller [baseline] (4.168 ms) : 0, 4168
Flare Poller [candidate] (4.079 ms) : 0, 4079
IAST [baseline] (31.65 ms) : 0, 31650
IAST [candidate] (33.243 ms) : 0, 33243
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (729.647 ms) : 0, 729647
BytebuddyAgent [candidate] (728.111 ms) : 0, 728111
GlobalTracer [baseline] (221.178 ms) : 0, 221178
GlobalTracer [candidate] (221.172 ms) : 0, 221172
AppSec [baseline] (32.316 ms) : 0, 32316
AppSec [candidate] (32.277 ms) : 0, 32277
Debugger [baseline] (9.944 ms) : 0, 9944
Debugger [candidate] (12.142 ms) : 0, 12142
Remote Config [baseline] (1.523 ms) : 0, 1523
Remote Config [candidate] (1.584 ms) : 0, 1584
Telemetry [baseline] (12.345 ms) : 0, 12345
Telemetry [candidate] (9.894 ms) : 0, 9894
Flare Poller [baseline] (4.124 ms) : 0, 4124
Flare Poller [candidate] (4.068 ms) : 0, 4068
ProfilingAgent [baseline] (109.636 ms) : 0, 109636
ProfilingAgent [candidate] (109.791 ms) : 0, 109791
Profiling [baseline] (110.314 ms) : 0, 110314
Profiling [candidate] (110.413 ms) : 0, 110413
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.255 ms) : 3208, 3302
. : milestone, 3255,
iast_FULL (5.587 ms) : 5532, 5642
. : milestone, 5587,
iast_GLOBAL (3.58 ms) : 3528, 3633
. : milestone, 3580,
profiling (2.056 ms) : 2038, 2073
. : milestone, 2056,
tracing (1.808 ms) : 1793, 1823
. : milestone, 1808,
section candidate
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.241 ms) : 3198, 3285
. : milestone, 3241,
iast_FULL (5.981 ms) : 5920, 6042
. : milestone, 5981,
iast_GLOBAL (3.66 ms) : 3610, 3711
. : milestone, 3660,
profiling (1.943 ms) : 1926, 1959
. : milestone, 1943,
tracing (1.889 ms) : 1871, 1907
. : milestone, 1889,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section baseline
no_agent (18.946 ms) : 18752, 19140
. : milestone, 18946,
appsec (19.447 ms) : 19242, 19652
. : milestone, 19447,
code_origins (19.518 ms) : 19321, 19716
. : milestone, 19518,
iast (18.331 ms) : 18150, 18512
. : milestone, 18331,
profiling (20.078 ms) : 19879, 20277
. : milestone, 20078,
tracing (18.412 ms) : 18230, 18594
. : milestone, 18412,
section candidate
no_agent (17.879 ms) : 17693, 18065
. : milestone, 17879,
appsec (19.437 ms) : 19236, 19638
. : milestone, 19437,
code_origins (19.208 ms) : 19017, 19399
. : milestone, 19208,
iast (18.385 ms) : 18199, 18572
. : milestone, 18385,
profiling (19.2 ms) : 19004, 19396
. : milestone, 19200,
tracing (19.53 ms) : 19332, 19729
. : milestone, 19530,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.467 ms) : 2416, 2518
. : milestone, 2467,
iast (2.203 ms) : 2139, 2266
. : milestone, 2203,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.501 ms) : 2328, 2674
. : milestone, 2501,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.641 ms) : 3428, 3853
. : milestone, 3641,
iast (2.21 ms) : 2146, 2274
. : milestone, 2210,
iast_GLOBAL (2.265 ms) : 2201, 2329
. : milestone, 2265,
profiling (2.064 ms) : 2012, 2115
. : milestone, 2064,
tracing (2.025 ms) : 1975, 2075
. : milestone, 2025,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~85ed98d2e0, baseline=1.55.0-SNAPSHOT~33bbc70b29
dateFormat X
axisFormat %s
section baseline
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
iast (18.544 s) : 18544000, 18544000
. : milestone, 18544000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
. : milestone, 17950000,
profiling (15.769 s) : 15769000, 15769000
. : milestone, 15769000,
tracing (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
appsec (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
iast (18.736 s) : 18736000, 18736000
. : milestone, 18736000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
tracing (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
|
4a46baf to
f8f26bf
Compare
f8f26bf to
cef2b46
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
| try { | ||
| log.debug("Getting OpenLineage conf from the listener"); | ||
| Object openLineageConf = listener.getClass().getMethod("getConf").invoke(listener); | ||
| if (openLineageConf != null) { | ||
| InstanceStore.of(SparkConf.class) | ||
| .put("openLineageSparkConf", (SparkConf) openLineageConf); | ||
| } | ||
| } catch (IllegalAccessException | NoSuchMethodException | InvocationTargetException e) { | ||
| log.warn( | ||
| "Issue when obtaining OpenLineage conf (possibly unsupported OpenLineage version): {}", | ||
| e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of reflection, we should find exactly the databricks forked class, and write an instrumentation similar to what we do for SparkConf itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try this @mobuchowski.
Reflection is a workaround for the LiveListenerBusAdvice not working on databricks.
d6565eb to
85ed98d
Compare
What Does This Do
Spark listeners on databricks environments are instantiated in slightly different way than on regular vanilla Spark setups. This PR assures the datadog listener instruments Openlineage listener correctly on the databricks environment.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]