Make sure checks.d directory is present #213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the following copy command will create a file called 'checks.d' for the first check file.
xvello
suggested changes
Jul 7, 2017
Contributor
xvello
left a comment
xvello
left a comment
There was a problem hiding this comment.
Hi @lgierth and thank you for your contribution. Indeed this is a bug in the current entrypoints.
-
To be consistent with how we handle
/conf.d, I'd go with
find /checks.d -name '*.py' -exec cp --parents {} /opt/datadog-agent/agent \;
instead. This makes cp create the parent folder if needed (and it is indeed needed). Would that be OK with you? -
You PR patches two entrypoints, but we have a third one in
jmx/entrypoint.sh. Could you please include this one as well?
Regards
Contributor
Author
|
Hey sorry I totally forgot about this -- crazy busy times right now. @aerostitch thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes sure the checks.d directory is present in the container.
Motivation
Otherwise the following copy command will create a file called 'checks.d' for the first check file.
We weren't previously able to mount a checks.d directory as a volume. The mounting-as-a-volume part worked, but the copying-to-the-actual-directory part was broken because the target checks.d directory within the container didn't exist.