-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add Developer Platform instructions #32481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
evazorro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few fixes and a note/question about formatting on some of the procedures. I'd love to take another look before merge.
Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
| Ensure following tools are installed: | ||
|
|
||
| ## Prerequisites | ||
| - Python v3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using Python 3.13 now - perhaps we could remove this step here since it's part of the ddev steps anyway?
| The following example shows logic for an integration named `Awesome`. | ||
|
|
||
| For Awesome, the Agent Check is composed of a [service check][25] named `awesome.search` that searches for a string on a web page. It results in `OK` if the string is present, `WARNING` if the page is accessible but the string was not found, and `CRITICAL` if the page is inaccessible. | ||
| This check defines a [service check][4] called `awesome.search`, which searches a webpage for a specific string: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-blocker) I'll make an issue to remove service checks from examples in general, we want to move away from them because metrics are better for the same purpose.
|
|
||
| <div class="alert alert-info">If you are creating an integration for the Datadog Marketplace, ensure that your directory follows the pattern of {partner name}_{integration name}.</div> | ||
| ```shell | ||
| ddev create -t check_only <YOUR_INTEGRATION_NAME> --skip-manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind using check_only?
What does this PR do? What is the motivation?
Add Developer Platform instructions for Agent-based integrations