Skip to content

[datadog] Change check-cluster-name regex #2428

Open
triviajon wants to merge 3 commits intomainfrom
triviajon/CONTINT-5127/kube_cluster_name
Open

[datadog] Change check-cluster-name regex #2428
triviajon wants to merge 3 commits intomainfrom
triviajon/CONTINT-5127/kube_cluster_name

Conversation

@triviajon
Copy link
Copy Markdown
Contributor

@triviajon triviajon commented Mar 2, 2026

What this PR does / why we need it:

This PR edits the regular expression used to validate cluster names to allow cluster names which start with a digit or contain underscores.

Context:

On EKS, clusters can be created with flexible naming conventions that include characters typically restricted (e.g., 0-my_cluster). When the agent is deployed without explicitly setting a clusterName, the agent successfully auto-detects the name via the EC2 Instance Metadata Service (IMDS).

However, explicitly setting datadog.clusterName: 0-my_cluster currently triggers validation failures at both the Helm chart and Agent levels.

Related to DataDog/datadog-agent#47189 and https://datadoghq.atlassian.net/browse/CONTINT-5127

Note to reviewers

This will not be merged until the release of v7.78

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Mar 2, 2026
@triviajon triviajon marked this pull request as ready for review March 3, 2026 18:50
@triviajon triviajon requested a review from a team as a code owner March 3, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart/datadog This issue or pull request is related to the datadog chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants