Open
Conversation
…h a digit, add relevant test
fanny-jiang
approved these changes
Mar 3, 2026
frank-spano
approved these changes
Mar 4, 2026
frank-spano
approved these changes
Mar 4, 2026
lavigne958
approved these changes
Mar 4, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR edits the regular expression used to validate cluster names to allow cluster names which start with a digit or contain underscores.
Context:
On EKS, clusters can be created with flexible naming conventions that include characters typically restricted (e.g.,
0-my_cluster). When the agent is deployed without explicitly setting a clusterName, the agent successfully auto-detects the name via the EC2 Instance Metadata Service (IMDS).However, explicitly setting
datadog.clusterName: 0-my_clustercurrently triggers validation failures at both the Helm chart and Agent levels.Related to DataDog/datadog-agent#47189 and https://datadoghq.atlassian.net/browse/CONTINT-5127
Note to reviewers
This will not be merged until the release of v7.78
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md