[DO NOT MERGE] [datadog-operator] 2.19.1: rollback registryMigrationMode and operator image registry#2452
Open
[DO NOT MERGE] [datadog-operator] 2.19.1: rollback registryMigrationMode and operator image registry#2452
Conversation
avonengel
added
chart/datadog-operator
Contributor
Author
|
@codex review |
AliDatadog
approved these changes
Mar 9, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df4343d413
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | podLabels | object | `{}` | Allows setting additional labels for for Datadog Operator PODs | | ||
| | rbac.create | bool | `true` | Specifies whether the RBAC resources should be created | | ||
| | registryMigrationMode | string | `"auto"` | Controls gradual migration of Agent image pulls to registry.datadoghq.com. When enabled, DD_REGISTRY_OVERRIDE_* environment variables are added to the Datadog Operator deployment to pull Agent images from the global CDN-backed registry.datadoghq.com based on the global.site setting, unless global.registry is specified in the DatadogAgent custom resource (which takes precedence). This has no effect on sites not covered by the active overrides. More sites will be enabled by default in future helm-chart releases. "auto" (default): enable overrides for sites where migration is rolled out. Currently enabled: AP1 (ap1.datadoghq.com). "all": enable all per-site overrides (AP1, US1, EU1, US3). "" or unset: disable all overrides. | | ||
| | registryMigrationMode | string | `""` | Controls gradual migration of Agent image pulls to registry.datadoghq.com. When enabled, DD_REGISTRY_OVERRIDE_* environment variables are added to the Datadog Operator deployment to pull Agent images from the global CDN-backed registry.datadoghq.com based on the global.site setting, unless global.registry is specified in the DatadogAgent custom resource (which takes precedence). This has no effect on sites not covered by the active overrides. More sites will be enabled by default in future helm-chart releases. "auto" (default): enable overrides for sites where migration is rolled out. Currently enabled: AP1 (ap1.datadoghq.com). "all": enable all per-site overrides (AP1, US1, EU1, US3). "" or unset: disable all overrides. | |
There was a problem hiding this comment.
This row now sets registryMigrationMode to "", but the same description still says "auto" (default), which makes the documented behavior self-contradictory. In environments relying on README values to plan upgrades, this can lead to expecting DD_REGISTRY_OVERRIDE_* env vars by default when they are actually disabled, so the default text should match the new value.
Useful? React with 👍 / 👎.
tbavelier
approved these changes
Mar 9, 2026
tbavelier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Precautionary rollback — do not merge unless the registry migration (PRs #2421 / #2430) needs to be reverted.
This PR is prepared in advance as a break-glass option. It should remain as a draft and only be merged if something goes wrong with the BARX-1655 registry migration rollout.
Changes:
registryMigrationMode: ""(disabled — noDD_REGISTRY_OVERRIDE_*env vars injected)gcr.io/datadoghq/operator2.19.1so it is picked up as the latest stable release without--develThe
registryMigrationModevalue and helper template are kept in place (not removed), so re-enabling the migration is a one-line change when ready.Which issue this PR fixes
Special notes for your reviewer:
Rollback of #2421 and #2430. Do not merge unless the registry migration needs to be reverted.
Checklist
datadog-operator/patch-version)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines).github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md