Skip to content

chore: add crdAnnotation to datadog-crds chart#2465

Open
v-starodubov wants to merge 3 commits intoDataDog:mainfrom
v-starodubov:main
Open

chore: add crdAnnotation to datadog-crds chart#2465
v-starodubov wants to merge 3 commits intoDataDog:mainfrom
v-starodubov:main

Conversation

@v-starodubov
Copy link
Copy Markdown

@v-starodubov v-starodubov commented Mar 11, 2026

What this PR does / why we need it:

Adds a crdAnnotations value to the datadog-crds chart that allows users to specify arbitrary annotations on all CRD resources. This is particularly useful for ArgoCD users who need annotations such as argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true to prevent sync errors when CRDs are not yet established in the cluster.

All 9 CRD templates have been updated to render crdAnnotations, and update-crds.sh has been updated to inject the block automatically on future CRD refreshes.

Example usage:

crdAnnotations:
  argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

  • crdAnnotations defaults to {} and is a no-op when not set — no changes to existing rendered output.
  • keepCrds behavior is unchanged; crdAnnotations is additive alongside it.
  • update-crds.sh sed injection updated so the block is preserved on future upstream CRD refreshes.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

Signed-off-by: Volodymyr Starodubov <volodymyr.starodubov@alpacked.io>
Signed-off-by: Volodymyr Starodubov <volodymyr.starodubov@alpacked.io>
@v-starodubov v-starodubov requested review from a team as code owners March 11, 2026 12:24
@v-starodubov v-starodubov changed the title chore: add crdAnnotation to helm charts chore: add crdAnnotation to datadog-crds chart Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CRDs too big for ArgoCD, adding annotation to CRDs would be an easy fix

1 participant