chore: add crdAnnotation to datadog-crds chart#2465
Open
v-starodubov wants to merge 3 commits intoDataDog:mainfrom
Open
chore: add crdAnnotation to datadog-crds chart#2465v-starodubov wants to merge 3 commits intoDataDog:mainfrom
crdAnnotation to datadog-crds chart#2465v-starodubov wants to merge 3 commits intoDataDog:mainfrom
Conversation
Signed-off-by: Volodymyr Starodubov <volodymyr.starodubov@alpacked.io>
Signed-off-by: Volodymyr Starodubov <volodymyr.starodubov@alpacked.io>
crdAnnotation to helm chartscrdAnnotation to datadog-crds chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a
crdAnnotationsvalue to thedatadog-crdschart that allows users to specify arbitrary annotations on all CRD resources. This is particularly useful for ArgoCD users who need annotations such asargocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=trueto prevent sync errors when CRDs are not yet established in the cluster.All 9 CRD templates have been updated to render
crdAnnotations, andupdate-crds.shhas been updated to inject the block automatically on future CRD refreshes.Example usage:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
crdAnnotationsdefaults to{}and is a no-op when not set — no changes to existing rendered output.keepCrdsbehavior is unchanged;crdAnnotationsis additive alongside it.update-crds.shsed injection updated so the block is preserved on future upstream CRD refreshes.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md