[INPLAT-1004]: expose registry allow list for DatadogLibrary volumes#2488
Open
[INPLAT-1004]: expose registry allow list for DatadogLibrary volumes#2488
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1be5d96510
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
knusbaum
changed the title
5 tasks
knusbaum
force-pushed
the
knusbaum/csi-driver-registry-allow-list
branch
2 times, most recently
from
701d911 to
b970c9e
Compare
github-actions
bot
added
the
chart/datadog
Adds apm.registryAllowList to the Helm chart, passed to the driver as DD_REGISTRY_ALLOW_LIST. When set, restricts which container registries can be used as sources for DatadogLibrary CSI volumes. Defaults to empty (all registries allowed). Bumps chart to v0.10.0. Replaces baseline snapshot test with targeted env var assertions using values files, covering non-empty, empty, and undefined list cases.
Template the datadog-csi-driver.apm.registryAllowList value as DD_ADMISSION_CONTROLLER_AUTO_INSTRUMENTATION_CSI_REGISTRY_ALLOW_LIST on the cluster-agent deployment. This allows the admission webhook to skip adding CSI volumes for libraries from disallowed registries.
knusbaum
force-pushed
the
knusbaum/csi-driver-registry-allow-list
branch
from
f3ea8cc to
2c6d5e2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c6d5e2b60
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
0.10.0 is not yet published to the Helm repo; bumping the dependency here breaks helm dependency build in CI. The bump will follow in a separate PR once this chart is released.
knusbaum
commented
Mar 19, 2026
The registry allow list is now enforced by the cluster-agent admission controller for all injection modes (init container, image volume, CSI). Move the configuration to clusterAgent.admissionController.containerRegistryAllowList and update the env var to DD_ADMISSION_CONTROLLER_AUTO_INSTRUMENTATION_CONTAINER_REGISTRY_ALLOW_LIST.
Use global.containerRegistryAllowList as a single config point that configures both the cluster-agent admission webhook and the CSI driver. The webhook skips mutation for blocked registries; the CSI driver independently enforces the same list via DD_REGISTRY_ALLOW_LIST. Bump bundled datadog-csi-driver sub-chart to 0.10.0.
When the datadog-csi-driver chart is rendered standalone (not as a sub-chart of the datadog chart), .Values.global is nil. The template was accessing .Values.global.containerRegistryAllowList on a nil map, causing a template rendering error. Add global.containerRegistryAllowList: [] to values.yaml so that the global key always exists with a safe default. This fixes the CI baseline tests that render the chart directly.
Contributor
|
@iamluc seems related to what you are working on ? Could you please have a look 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apm.registryAllowListto thedatadog-csi-driverHelm chartDD_REGISTRY_ALLOW_LIST(comma-joined), restricting which container registries can be used as sources for DatadogLibrary CSI volumes0.10.0Test plan
TestRegistryAllowListverifiesDD_REGISTRY_ALLOW_LISTis set correctly whenregistryAllowListis non-emptyTestRegistryAllowListverifiesDD_REGISTRY_ALLOW_LISTis absent whenregistryAllowListis explicitly set to[](via values file)TestRegistryAllowListverifiesDD_REGISTRY_ALLOW_LISTis absent whenregistryAllowListis undefined (no values file)Closes INPLAT-1004