Skip to content

[CXP-2640] Remove run_in_core_agent envvar override and cleanup#2520

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
daniel.tafoya/cxp-2639-version-aware-run-in-core-agent
Apr 1, 2026
Merged

[CXP-2640] Remove run_in_core_agent envvar override and cleanup#2520
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
daniel.tafoya/cxp-2639-version-aware-run-in-core-agent

Conversation

@daniel-taf
Copy link
Copy Markdown
Contributor

@daniel-taf daniel-taf commented Mar 27, 2026

Summary

Aligns with datadog-operator#2841. As of Agent 7.78, process_config.run_in_core_agent.enabled was removed (datadog-agent#47902).

  • Remove the envvar override check (get-process-checks-in-core-agent-envvar helper) — respecting user overrides of a deprecated envvar no longer makes sense
  • Remove DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED=false from cluster-checks-runner and otel-agent-gateway defaults
  • Remove datadog.processAgent.runInCoreAgent yaml-mapper mapping
  • When doNotCheckTag is true, assume the agent supports run-in-core-agent (>= 7.60) rather than falling back to the most conservative behavior. Our agent e2e testing infrastructure uses this and the current behavior prevents proper e2e tests on K8s with this feature.
  • Features still inject the envvar for backward compatability

Test plan

  • Test_processAgentConfigs — all cases pass
  • Test_baseline_inputs — baselines updated and passing
  • CI checks

🤖 Generated with Claude Code

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Mar 27, 2026
@daniel-taf daniel-taf changed the title [CXP-2639] Stop injecting DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED for agents >= 7.78 [CXP-2639] Remove run_in_core_agent envvar override and cleanup Mar 27, 2026
@daniel-taf daniel-taf changed the title [CXP-2639] Remove run_in_core_agent envvar override and cleanup [CXP-2640] Remove run_in_core_agent envvar override and cleanup Mar 27, 2026
@daniel-taf daniel-taf marked this pull request as ready for review March 27, 2026 20:37
@daniel-taf daniel-taf requested review from a team as code owners March 27, 2026 20:37
daniel-taf and others added 3 commits March 31, 2026 17:52
… for agents >= 7.78

The process_config.run_in_core_agent.enabled config key was removed in
agent 7.78.0 (datadog-agent#47902). This change adds version-aware logic
to stop injecting the envvar for agents >= 7.78, keep it for 7.60–7.77,
and maintain backward compat for < 7.60.

Also updates doNotCheckTag behavior to assume the agent supports
run-in-core-agent (>= 7.60) rather than falling back to the most
conservative behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Align with datadog-operator#2841:
- Remove envvar override check (get-process-checks-in-core-agent-envvar)
- Remove DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED from cluster-checks-runner
  and otel-agent-gateway defaults
- Remove datadog.processAgent.runInCoreAgent yaml-mapper mapping
- When doNotCheckTag is true, assume agent supports run-in-core-agent
- Features still inject the envvar for backward compat with agents < 7.78

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@daniel-taf daniel-taf force-pushed the daniel.tafoya/cxp-2639-version-aware-run-in-core-agent branch from ecffba5 to b0e4c91 Compare March 31, 2026 17:53
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@daniel-taf
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 1, 2026

View all feedbacks in Devflow UI.

2026-04-01 14:55:40 UTC ℹ️ Start processing command /merge


2026-04-01 14:55:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-04-01 16:21:06 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit c72f000 into main Apr 1, 2026
39 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the daniel.tafoya/cxp-2639-version-aware-run-in-core-agent branch April 1, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants