[CXP-2640] Remove run_in_core_agent envvar override and cleanup#2520
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom Apr 1, 2026
Conversation
swang392
approved these changes
Mar 31, 2026
… for agents >= 7.78 The process_config.run_in_core_agent.enabled config key was removed in agent 7.78.0 (datadog-agent#47902). This change adds version-aware logic to stop injecting the envvar for agents >= 7.78, keep it for 7.60–7.77, and maintain backward compat for < 7.60. Also updates doNotCheckTag behavior to assume the agent supports run-in-core-agent (>= 7.60) rather than falling back to the most conservative behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Align with datadog-operator#2841: - Remove envvar override check (get-process-checks-in-core-agent-envvar) - Remove DD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED from cluster-checks-runner and otel-agent-gateway defaults - Remove datadog.processAgent.runInCoreAgent yaml-mapper mapping - When doNotCheckTag is true, assume agent supports run-in-core-agent - Features still inject the envvar for backward compat with agents < 7.78 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ecffba5 to
b0e4c91
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns with datadog-operator#2841. As of Agent 7.78,
process_config.run_in_core_agent.enabledwas removed (datadog-agent#47902).get-process-checks-in-core-agent-envvarhelper) — respecting user overrides of a deprecated envvar no longer makes senseDD_PROCESS_CONFIG_RUN_IN_CORE_AGENT_ENABLED=falsefrom cluster-checks-runner and otel-agent-gateway defaultsdatadog.processAgent.runInCoreAgentyaml-mapper mappingdoNotCheckTagis true, assume the agent supports run-in-core-agent (>= 7.60) rather than falling back to the most conservative behavior. Our agent e2e testing infrastructure uses this and the current behavior prevents proper e2e tests on K8s with this feature.Test plan
Test_processAgentConfigs— all cases passTest_baseline_inputs— baselines updated and passing🤖 Generated with Claude Code