Skip to content

Conversation

@pierreln-dd
Copy link
Contributor

What does this PR do?

Clarifies that postgresql.duration.* metrics (based on pg_stat_statement) are the values of completed queries

Motivation

Customer feedback

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (95abfe3) to head (182660b).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nenadnoveljic
nenadnoveljic previously approved these changes Nov 13, 2025
Change from completed to executed
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nenadnoveljic’s stale review November 13, 2025 08:56

Review from nenadnoveljic is dismissed. Related teams and files:

  • database-monitoring-agent
    • postgres/metadata.csv
nenadnoveljic
nenadnoveljic previously approved these changes Nov 13, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nenadnoveljic’s stale review November 13, 2025 09:09

Review from nenadnoveljic is dismissed. Related teams and files:

  • database-monitoring-agent
    • postgres/metadata.csv
@nenadnoveljic
Copy link
Member

Is there a Jira card to link to this PR?

nenadnoveljic
nenadnoveljic previously approved these changes Nov 19, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nenadnoveljic’s stale review November 20, 2025 14:15

Review from nenadnoveljic is dismissed. Related teams and files:

  • database-monitoring-agent
    • postgres/datadog_checks/postgres/data/conf.yaml.example
@github-actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
postgres/datadog_checks/postgres/data/conf.yaml.example

@pierreln-dd
Copy link
Contributor Author

I had an out-of date ddev version, decided it was easier to start fresh on a new PR: #21934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants