Skip to content

Conversation

@Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Jan 20, 2026

This PR includes the following changes:

  • The coverage upload jobs have been split to avoid the deployment errors on non-master branches.
  • The release job should now automatically upload release notes.
  • Relevant documentation has now been moved under docs/
  • Some documentation has been written through codex and claude, albeit most of it is preliminary and needs extensive work before considered accurate enough (this will be done over time...).
  • The following docs are stable:
    • docs/changelog/*
    • docs/upgrading/*
    • docs/allocators.md

@Anilm3 Anilm3 had a problem deploying to dd-protected-coverage January 20, 2026 18:36 — with GitHub Actions Failure
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 2027984 2004032 -1.18%
darwin-universal::libddwaf.dylib 4256208 4215872 -0.94%
darwin-x86_64::libddwaf.dylib 2213736 2195712 -0.81%
linux-aarch64::libddwaf.so 2463376 2378224 -3.45%
linux-armv7::libddwaf.so 2148940 2046280 -4.77%
linux-i386::libddwaf.so 2392980 2300828 -3.85%
linux-x86_64::libddwaf.so 2660256 2571120 -3.35%
windows-arm64::ddwaf.dll 4790272 6686208 39.57%
windows-win32::ddwaf.dll 3368960 3315712 -1.58%
windows-x64::ddwaf.dll 4102656 4045824 -1.38%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 91537528 92215128 0.74%
darwin-arm64::libddwaf.a.stripped 4582760 4707464 2.72%
darwin-universal::libddwaf.a 184432872 185945888 0.82%
darwin-universal::libddwaf.a.stripped 9776864 10023864 2.52%
darwin-x86_64::libddwaf.a 92895296 93730712 0.89%
darwin-x86_64::libddwaf.a.stripped 5194056 5316352 2.35%
linux-aarch64::libddwaf.a 73173714 75161592 2.71%
linux-aarch64::libddwaf.a.stripped 11851494 12162860 2.62%
linux-armv7::libddwaf.a 64732098 66399138 2.57%
linux-armv7::libddwaf.a.stripped 10852278 11168358 2.91%
linux-i386::libddwaf.a 62858558 64591428 2.75%
linux-i386::libddwaf.a.stripped 9379838 9661240 3.00%
linux-x86_64::libddwaf.a 73660850 75652672 2.70%
linux-x86_64::libddwaf.a.stripped 11670798 11966124 2.53%
windows-arm64::ddwaf.lib 11698 16410 40.27%
windows-arm64::ddwaf_static.lib 57964164 134528158 132.08%
windows-win32::ddwaf.lib 11922 16726 40.29%
windows-win32::ddwaf_static.lib 49576448 47564214 -4.05%
windows-x64::ddwaf.lib 11698 16410 40.27%
windows-x64::ddwaf_static.lib 57456080 55369970 -3.63%

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks clang-pgo

Benchmark execution time: 2026-01-21 17:02:56

Comparing candidate commit b2a95f1 in PR branch anilm3/v2-docs with baseline commit 70719dc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Refactored the upload-coverage job into three distinct jobs:
- generate-coverage: merges coverage data and creates artifacts
- upload-to-codecov: uploads coverage to CodeCov (runs on all branches)
- upload-to-datadog: uploads coverage to DataDog (master branch only)

This separation allows parallel uploads and restricts DataDog uploads to production deployments.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.92%. Comparing base (70719dc) to head (7e90a34).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         190      190           
  Lines        9203     9203           
  Branches     4143     4143           
=======================================
  Hits         7816     7816           
  Misses        509      509           
  Partials      878      878           
Flag Coverage Δ
waf_test 84.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Anilm3 and others added 6 commits January 21, 2026 10:20
- Replace ddwaf_init/ddwaf_update with ddwaf_builder API
- Fix function signatures (add allocator parameters)
- Add ddwaf_builder lifecycle documentation
- Add note about ddwaf_subcontext thread safety
- Remove outdated allocator and diagnostics sections
- Fix grammar: "put in other words" -> "or in other words"

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
API reference (docs/c-api/api.md):
- Clarify that output_alloc is for result objects in eval functions
- Fix critical error: result must be destroyed with output_alloc, not alloc parameter
- Improve thread safety description for WAF handles

Upgrading guide (docs/upgrading/UPGRADING-v2.0.md):
- Use consistent British spelling throughout
- "Context Initialization" → "Context Initialisation"
- "Preallocated and preinitialised" → "Pre-allocated and pre-initialised"

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@cataphract cataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but infer_schema.cpp also needs to be looked at

@Anilm3 Anilm3 marked this pull request as ready for review January 21, 2026 14:11
@Anilm3 Anilm3 requested a review from a team as a code owner January 21, 2026 14:11
@Anilm3 Anilm3 requested a review from cataphract January 21, 2026 14:52
@DataDog DataDog deleted a comment from chatgpt-codex-connector bot Jan 21, 2026
@Anilm3 Anilm3 enabled auto-merge (squash) January 21, 2026 17:28
@Anilm3 Anilm3 merged commit cf49c49 into master Jan 21, 2026
56 of 57 checks passed
@Anilm3 Anilm3 deleted the anilm3/v2-docs branch January 21, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants