Skip to content

Conversation

@chouetz
Copy link
Member

@chouetz chouetz commented Feb 11, 2025

Description

  • Pin the github actions
  • Enable dependabot

Aside from the PR the workflows settings had been updated to allow only the listed actions we need

Briefly describe the new feature or fix here


/cc @chef/omnibus-maintainers <- This ensures the Omnibus Maintainers team are notified to review this PR.

@chouetz chouetz requested a review from a team as a code owner February 11, 2025 17:06
@github-actions github-actions bot added the no-auto-bump PRs with this label will NOT automatically open a bump PR in datadog-agent label Feb 11, 2025
@chouetz chouetz force-pushed the nschweitzer/pin_actions branch from c6904b0 to 8a8d963 Compare February 11, 2025 17:10
@chouetz
Copy link
Member Author

chouetz commented Feb 12, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 12, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-12 06:44:32 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in datadog-5.5.0 is 0s.


2025-02-12 08:44:41 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'datadog-5.5.0' is 120 minutes.

@chouetz chouetz merged commit 28fec93 into datadog-5.5.0 Feb 12, 2025
3 of 4 checks passed
@chouetz chouetz deleted the nschweitzer/pin_actions branch February 12, 2025 09:48
Pythyu added a commit that referenced this pull request Mar 21, 2025
* Support an explicit target install location for macOS packages (#215)

* configure: use the expected default value for windows prefix (#216)

* use the expected default value for windows prefix

* allow --build to be ommited from configure args

* replace unless with if not

* Always ship source/source offers (#217)

* software: always ship the source or source offer

Even when restoring the build from cache

* attempt clean instead of deployed

deploy isn't available for all fetchers

* [BARX-775] Clone directly to the right revision (#218)

* Replace git clone by git fetch to the right version

* add log

* feat(security): Pin github actions (#219)

* add a disable_version_manifest accessor (#220)

* add a disable_version_manifest accessor

* allow version manifests to be disabled

* remove an extra blank line to keep rubocop happy

* fix syntax

* project: fix typo preventing overriding version manifest file (#222)

* project: provide a default value for disable_version_manifest (#221)

* cli: rely on the existing use_s3_caching option to enable caching (#223)

* cli: rely on the existing use_s3_caching option to enable caching

* cli: remove now unused populate_s3_cache option

* don't attempt to populate cache when we only have read access

* add a comment to clarify the logic

* feat(bump): Remove homemade workflow to use renovate instead (#224)

* [PathFetcher] Improve speed by removing unnecessary digest operations (#225)

Improves the PathFetcher class' speed by removing some digest operations that are not neccesary, since they are quite costly (10-15s for a large directory like the datadog-agent repository).

Specifically:
- if the target directory (in the omnibus project directories) is empty, force a fetch without computing the digests of the source and the target: in this case, we know a fetch is required.
- after a fetch, do not pre-compute the digest of the target directory. In practice, it is a useless operation because this digest is never reused in the same omnibus run.

I expect these improvements to reduce the duration of all Agent builds by about 30s.

---------

Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com>
Co-authored-by: Hugo Beauzée-Luyssen <hugo.beauzee@datadoghq.com>
Co-authored-by: AliDatadog <125997632+AliDatadog@users.noreply.github.com>
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergequeue-status: rejected no-auto-bump PRs with this label will NOT automatically open a bump PR in datadog-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants