add a disable_version_manifest accessor #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/omnibus/project.rb
Outdated
| @disable_version_manifest = val | ||
| end | ||
| end | ||
| expose disable_version_manifest |
Member
There was a problem hiding this comment.
Should it be
Suggested change
| expose disable_version_manifest | |
| expose :disable_version_manifest |
?
FlorentClarret
approved these changes
Feb 20, 2025
Pythyu
added a commit
that referenced
this pull request
Mar 21, 2025
* Support an explicit target install location for macOS packages (#215) * configure: use the expected default value for windows prefix (#216) * use the expected default value for windows prefix * allow --build to be ommited from configure args * replace unless with if not * Always ship source/source offers (#217) * software: always ship the source or source offer Even when restoring the build from cache * attempt clean instead of deployed deploy isn't available for all fetchers * [BARX-775] Clone directly to the right revision (#218) * Replace git clone by git fetch to the right version * add log * feat(security): Pin github actions (#219) * add a disable_version_manifest accessor (#220) * add a disable_version_manifest accessor * allow version manifests to be disabled * remove an extra blank line to keep rubocop happy * fix syntax * project: fix typo preventing overriding version manifest file (#222) * project: provide a default value for disable_version_manifest (#221) * cli: rely on the existing use_s3_caching option to enable caching (#223) * cli: rely on the existing use_s3_caching option to enable caching * cli: remove now unused populate_s3_cache option * don't attempt to populate cache when we only have read access * add a comment to clarify the logic * feat(bump): Remove homemade workflow to use renovate instead (#224) * [PathFetcher] Improve speed by removing unnecessary digest operations (#225) Improves the PathFetcher class' speed by removing some digest operations that are not neccesary, since they are quite costly (10-15s for a large directory like the datadog-agent repository). Specifically: - if the target directory (in the omnibus project directories) is empty, force a fetch without computing the digests of the source and the target: in this case, we know a fetch is required. - after a fetch, do not pre-compute the digest of the target directory. In practice, it is a useless operation because this digest is never reused in the same omnibus run. I expect these improvements to reduce the duration of all Agent builds by about 30s. --------- Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com> Co-authored-by: Hugo Beauzée-Luyssen <hugo.beauzee@datadoghq.com> Co-authored-by: AliDatadog <125997632+AliDatadog@users.noreply.github.com> Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com> Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow version manifest not to be generated