Skip to content

use the usual package output directory for build summary #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chouquette wants to merge 2 commits into
base: datadog-5.5.0
Choose a base branch
from
Open

use the usual package output directory for build summary #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d867df5
use the usual package output directory for build summary
chouquette Jun 24, 2025
5d27e76
don't hardcode version manifest path
chouquette Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/omnibus/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ def build(name)
project.build

if @options[:output_manifest]
FileUtils.mkdir_p("pkg")
File.open(::File.join("pkg", "version-manifest.json"), "w") do |f|
FileUtils.mkdir_p(Omnibus::Config.package_dir)
File.open(::File.join(Omnibus::Config.package_dir, "version-manifest.json"), "w") do |f|
f.write(FFI_Yajl::Encoder.encode(project.built_manifest.to_hash))
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/omnibus/project.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,7 @@ def store_package_duration(packager, duration)
end

def write_build_summary
out_path = "#{Config.project_root}/pkg/build-summary.json"
out_path = "#{Config.package_dir}/build-summary.json"
log.info(log_key) { "Writing build summary to #{out_path}" }
File.open(out_path, "w") do |f|
f.write(FFI_Yajl::Encoder.encode(build_summary.to_hash, pretty: true))
Expand Down