This repository was archived by the owner on Jun 5, 2025. It is now read-only.
curl: don't provide path to dependencies #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouquette
force-pushed
the
chouquette/fix_curl_deps_rpath
branch
4 times, most recently
from
dc20471 to
e5e9f7b
Compare
Let pkg-config do its job instead. This fix a potential issue (most likely only in more recent toolchains than the one we use in the build images) where curl would explicitly depend on the absolute path to its dependencies, causing it to link with /path/to/libfoo.so instead of -lfoo When linking with an absolute path, the linker appears to not include the rpath information, which causes linking errors down the line: 2023-10-25T15:16:09+00:00 | /opt/toolchains/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.4.0/../../../../x86_64-u nknown-linux-gnu/bin/ld.bfd: warning: libnghttp2.so.14, needed by ../lib/.libs/libcurl.so, not found (try using -rpath or -rpath-link)
It's not default enabled to this doesn't have include any behavior change, however we are now sure that libidn will not be enabled in curl if we were to start building it
with-ssl was deprecated in 7bdec2a08bf025d2f66c168111d47df6b21890d9
10 tasks
chouquette
force-pushed
the
chouquette/fix_curl_deps_rpath
branch
from
f450ec5 to
87c57cb
Compare
spencergilbert
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test build at: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/22337037
Let pkg-config do its job instead. This fix a potential issue (most likely only
in more recent toolchains than the one we use in the build images) where curl
would explicitly depend on the absolute path to its dependencies, causing it to
link with /path/to/libfoo.so instead of -lfoo
When linking with an absolute path, the linker appears to not include the rpath
information, which causes linking errors down the line: