fix: catch RuntimeError during numba import fallback#86
Merged
florent-pajot merged 6 commits intomainfrom Feb 17, 2026
Merged
Conversation
When numba is installed but cannot initialize its cache (e.g., on read-only filesystems in Docker), it raises RuntimeError instead of ImportError. The except clause now catches both exception types to gracefully fall back to the NumPy implementation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adedaran
previously approved these changes
Feb 16, 2026
Remove tests that only verify Python try/except works. Keep the functional test that validates Slicefinder produces correct results with NUMBA_AVAILABLE=False. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adedaran
previously approved these changes
Feb 16, 2026
Notebook depends on OpenML API which causes flaky CI due to rate limiting. The notebook is a demo artifact, not a test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adedaran
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeErrorinstead ofImportErrorexcept ImportErrorclause inslicefinder.pydid not catch this, causing the import to crash instead of falling back to NumPyexcept (ImportError, RuntimeError)so both failure modes gracefully disable numba accelerationContext
This was observed in production with
tr-lucene-finder==0.7.0(which depends onsliceline==0.3.0). The Docker job environment has numba installed but the filesystem doesn't allow cache writes, producing:Test plan
TestNumbaFallbacktest class with 3 tests covering RuntimeError, ImportError, and Slicefinder functionality without numba🤖 Generated with Claude Code