This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Move to single constraint input #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I did some (stupid) testing and did not encounter any obvious problems with the syntax checking (however, after scrolling the view is broken): |
01Parzival10
approved these changes
Jul 14, 2025
Contributor
01Parzival10
left a comment
01Parzival10
left a comment
There was a problem hiding this comment.
LGTM
Constraints with newlines will not work until the backend is updated since the DSL parser cant work with them. Removing them in the Online Editor makes no sense though since that would remove the formatting added
Nicolas-Boltz
approved these changes
Jul 17, 2025
Member
Nicolas-Boltz
left a comment
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
LGTM
Lets get this into the main :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the constraint input with a single larger text field.
It also adapts to the new named syntax