Feature-114: NonMatchingChecksumException hexDigests Inclusion #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FileHashStore' and 'FileHashStoreLinks'
…ngChecksumException' is thrown and fix innacurate javadoc for a junit test
taojing2002
reviewed
Nov 13, 2024
src/test/java/org/dataone/hashstore/filehashstore/FileHashStoreProtectedTest.java
Show resolved
Hide resolved
taojing2002
reviewed
Nov 13, 2024
| public class NonMatchingChecksumException extends IllegalArgumentException { | ||
|
|
||
| public NonMatchingChecksumException(String message) { | ||
| private final Map<String, String> hexDigests; |
Contributor
There was a problem hiding this comment.
Did you check code to make sure if the hexDigests can be null or not?
taojing2002
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
NonMatchingChecksumExceptionexception is thrown, the hexDigests calculated during the process is included as an attribute of theNonMatchingChecksumExceptionclass, and a new methodgetHexDigestscan be called to retrieve the calculated list.