-
Notifications
You must be signed in to change notification settings - Fork 1
Switch dependency manager from poetry to uv #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@datadavev this looks great in general, but I notice its not passing GHA tests on python 3.10 -- once that gets patched up I think we could merge this. |
|
Oh, and we probably should also expand our testing matrix to include more recent python versions beyond 3.10 -- not sure why they were omitted. |
doulikecookiedough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @datadavev, I tested this branch and it's working well for me. It's good to merge after addressing Matt's feedback. I also updated the README.md with instructions on how to install uv, linking to your gist.
doulikecookiedough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added python 3.11 to the github workflow to be tested, and also resolved the issue with python 3.10 as well.
One side question - do we want to merge directly to main, or to develop? Either way I think this is ready to merge.
|
It should get merged to |
|
I think we should wait for other changes to occur before a release gets made 🙏 |
|
Merge to develop is preferred - I just didn't see the develop branch buried in the many old branches. |
Updates project to use uv for dependency management.