Open
Conversation
Contributor
geek
commented
Nov 19, 2019
geek
commented
- The PerformancePolicy is now populated when retrieving a volume
- Filters are now applied on listing
Member
|
Looks good to me. @NaveenSreeramachandra is running a regression test today and we'll merge the PR. Thank you for the contribution. |
willgorman
pushed a commit
to willgorman/go-datera
that referenced
this pull request
Feb 4, 2020
…xt-propagation Allow users to supply a custom http.Client
Add local snapshot promotion API
Avoid replacing any original ApiErrorResponse message on an unmarshal…
aligns field with API response
Placement policy api calls
Disable log flooding from tests
Merge 3.3.5 changes from upstream
* Hold the mutex for the entire Login function * Avoid deadlocks from attempting to take the lock from a function called during Login by adding a flag to signal when there is a Login active This addresses an issue introduced by Datera@e6ba24e#diff-ef40b515fe10f46d6039cce834cfe529R403 where moving the lock to after the PUT /login would allow concurrent unnecessary login calls. It also ensures that once a Login call acquires the lock it will exit without calling /login if a previous login has succeded
Instead of a flag for loggingIn state that affects all calls to connection, pass a flag on the call to `do` to prevent deadlocks on reentrant login calls while still allowing other goroutines to attempt to retry a request after relogin if necessary
Disallow concurrent logins
* UserLogFieldsCtxKey allows sdk users to attach fields to logs * request_route includes a canonicalized form of the path without ids/names
Add more logging fields for requests
Add user_data API
Add Type and ClusterId to snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.