bugfix: error when auto-generate IQN based on hostname including '_'#12
Open
ls-zhu wants to merge 1 commit intoDatera:masterfrom
ls-zhu:master
Open
bugfix: error when auto-generate IQN based on hostname including '_'#12ls-zhu wants to merge 1 commit intoDatera:masterfrom ls-zhu:master
ls-zhu wants to merge 1 commit intoDatera:masterfrom
ls-zhu:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This patch can fix a bug ： we will see a failure when try to create a IQN automaticly based on host name including "_":
izhu@Leap_Targetcli3:~/workspace/rtslib> hostname
Leap_Targetcli3
(1) auto-generate case based on my hostname "Leap_Targetcli3" which include a "_"
/> iscsi/ create
Created target iqn.2003-01.org.linux-iscsi.leap-targetcli3.x8664:sn.e7d6f4c4faf6.
Selected TPG Tag 1.
Created TPG 1.
(2) specify a iqn name includes a "_"
/> iscsi/ create iqn.2016-01.suse.com_aa_bb_cc
Created target iqn.2016-01.suse.com-aa-bb-cc.
Selected TPG Tag 1.
Created TPG 1.
/>