Skip to content

Add qla2xxx_wwn WWN type#5

Open
bootc wants to merge 1 commit intoDatera:masterfrom
bootc:master
Open

Add qla2xxx_wwn WWN type#5
bootc wants to merge 1 commit intoDatera:masterfrom
bootc:master

Conversation

@bootc
Copy link
Copy Markdown

@bootc bootc commented Dec 17, 2014

The qla2xxx_wwn type is used in policy/fabric_qla2xxx.lio but is not a
valid type in rtslib.config.Config.validate_val(). This commit adds
validation for this type in rtslib.config.Config.validate_val() and
rtslib.utils.is_valid_wwn().

This allows a system with existing targets (created by an older
targetcli/lio-utils) to be validated by rtslib and for the configuration
to be saved.

Signed-off-by: Chris Boot bootc@bootc.net

The qla2xxx_wwn type is used in policy/fabric_qla2xxx.lio but is not a
valid type in rtslib.config.Config.validate_val(). This commit adds
validation for this type in rtslib.config.Config.validate_val() and
rtslib.utils.is_valid_wwn().

This allows a system with existing targets (created by an older
targetcli/lio-utils) to be validated by rtslib and for the configuration
to be saved.

Signed-off-by: Chris Boot <bootc@bootc.net>
@tramjoe
Copy link
Copy Markdown
Contributor

tramjoe commented Dec 18, 2014

Hi Chris,

Thanks for the report, this will be fixed soon.
I am not sure what happened there, I think I messed it up when merging
local trees. Will check that out real soon.

Best Regards,

Jerome

On 12/17/2014 10:59 PM, Chris Boot wrote:

The qla2xxx_wwn type is used in policy/fabric_qla2xxx.lio but is not a
valid type in rtslib.config.Config.validate_val(). This commit adds
validation for this type in rtslib.config.Config.validate_val() and
rtslib.utils.is_valid_wwn().

This allows a system with existing targets (created by an older
targetcli/lio-utils) to be validated by rtslib and for the configuration
to be saved.

Signed-off-by: Chris Boot bootc@bootc.net mailto:bootc@bootc.net


    You can merge this Pull Request by running

git pull https://github.com/bootc/rtslib master

Or view, comment on, or merge it at:

#5

    Commit Summary


Reply to this email directly or view it on GitHub
#5.

@fulljackz
Copy link
Copy Markdown

Hi,

These PR solve this bug : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764005 on Proxmox 4 with Debian Jessie and 4.2 Kernel

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants