Skip to content

bugfix:creation of fileio backend target silently fails if size not specified #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ls-zhu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix:creation of fileio backend target silently fails if size not specified #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion targetcli/ui_backstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,23 @@ def ui_command_create(self, name, file_or_dev, size=None,
# use given file size only if backing file does not exist
if os.path.isfile(file_or_dev):
new_size = str(os.path.getsize(file_or_dev))
if size:
if new_size:
self.shell.log.info("%s exists, using its size (%s bytes)"
" instead"
% (file_or_dev, new_size))
size = new_size
backstore = FileIOBackstore(self.next_hba_index(), mode='create')
try:
so = FileIOStorageObject(
backstore, name, file_or_dev,
size,
buffered_mode=self.prm_buffered(buffered))
except Exception, exception:
backstore.delete()
raise exception
self.shell.log.info("Created fileio %s." % name)
ui_so = UIStorageObject(so, self)
return self.new_node(ui_so)
elif os.path.exists(file_or_dev):
raise ExecutionError("Path %s exists but is not a file" % file_or_dev)
else:
Expand Down