Conversation
add quick and dirty retry logic Add embed retry configuration update readme and variable names Adapt regular conversion w/ embed options Add missing comma.... fix warnings
DaveyJonesBitPail
force-pushed
the
feat/add-embed-retry
branch
from
2793ac8 to
c2c1524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a staging PR to prepare a PR for upstream
Background/Motivation: In certain environments modifying resources in PE files will fail on initial attempts due to interference from underlying systems. For example enterprise environments with aggressive defender profiles with the usage of Trusted DevDrives.
This change aims to allow configuration for retrying actual embedding of the generated type library as an opt-in, without changing default behavior.