fix(causal): tolerate minor rho proxy overshoot#3
Conversation
Keep the reproduction running when the rho proxy exceeds the target by a tiny numerical margin. The clamp still fails on real regressions, but it no longer aborts the sweep for a 0.000199 overshoot in the proxy check.
|
Caution Review failedThe pull request is closed. βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: π Files selected for processing (1)
π WalkthroughWalkthroughThe change refactors the rho-value threshold validation in the causal intervention script, transitioning from a strict per-channel check to a margin-based comparison using the maximum post-clamp rho value. Error reporting and debug logging are updated to reflect this new tolerance mechanism. Changes
Estimated code review effortπ― 2 (Simple) | β±οΈ ~12 minutes Possibly related PRs
Poem
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
π Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep the reproduction running when the rho proxy exceeds the target by a tiny numerical margin.
The clamp still fails on real regressions, but it no longer aborts the sweep for a 0.000199 overshoot in the proxy check.
Summary by CodeRabbit