Open
Conversation
febos
reviewed
Apr 7, 2020
Collaborator
febos
left a comment
febos
left a comment
There was a problem hiding this comment.
-
используйте .gitignore для pycache
-
не указано, какой модуль является исполняемым
-
После "You Win" программу невозможно закрыть
-
2-х башен хватило для победы, скуууучно :)
-
см. замечания по коду
-
у вас неделя на следующую итерацию. мерджите ветки, правите код, делаете новый реквест.
Enemy.py
Outdated
Comment on lines
+19
to
+30
| self.img_left = [pygame.image.load("run_left (1).png"), pygame.image.load("run_left (2).png"), | ||
| pygame.image.load("run_left (3).png"), pygame.image.load("run_left (4).png"), | ||
| pygame.image.load("run_left (5).png"), pygame.image.load("run_left (6).png"), | ||
| pygame.image.load("run_left (7).png"), pygame.image.load("run_left (8).png"), | ||
| pygame.image.load("run_left (9).png"), pygame.image.load("run_left (10).png"), | ||
| pygame.image.load("run_left (11).png")] | ||
| self.img_right = [pygame.image.load("run_right (1).png"), pygame.image.load("run_right (2).png"), | ||
| pygame.image.load("run_right (3).png"), pygame.image.load("run_right (4).png"), | ||
| pygame.image.load("run_right (5).png"), pygame.image.load("run_right (6).png"), | ||
| pygame.image.load("run_right (7).png"), pygame.image.load("run_right (8).png"), | ||
| pygame.image.load("run_right (9).png"), pygame.image.load("run_right (10).png"), | ||
| pygame.image.load("run_right (11).png")] |
Collaborator
There was a problem hiding this comment.
переделайте по-человечески в 2 строчки
Enemy.py
Outdated
Comment on lines
+43
to
+44
| self.x += (x2 - x1) / math.sqrt((x2 - x1) ** 2 + (y2 - y1) ** 2) * self.vel | ||
| self.y += (y2 - y1) / math.sqrt((x2 - x1) ** 2 + (y2 - y1) ** 2) * self.vel |
Collaborator
There was a problem hiding this comment.
избегайте повторяющихся кусков кода
Enemy.py
Outdated
Comment on lines
+67
to
+68
| pygame.draw.rect(win, (255, 0, 0), (self.x - self.width // 2, self.y - self.height // 2, length, 10), 0) | ||
| pygame.draw.rect(win, (0, 255, 0), (self.x - self.width // 2, self.y - self.height // 2, health_bar, 10), 0) |
Game.py
Outdated
Comment on lines
+69
to
+71
| self.tower_place = [[281, 153 - 40, False], [447, 152 - 40, False], [656, 166 - 40, False], | ||
| [546, 341 - 40, False], [270, 387 - 40, False], | ||
| [363, 514 - 40, False], [539, 515 - 40, False]] |
Towers.py
Outdated
Comment on lines
+56
to
+57
| self.img_per = [pygame.image.load("38.png"), pygame.image.load("39.png"), pygame.image.load("40.png"), | ||
| pygame.image.load("41.png"), pygame.image.load("42.png"), pygame.image.load("43.png")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Запускал код на PyCharm версия 3.7 с установаленным pygame. Запускается сочетанием клавишь Ctrl+Shift+F10. Проект представляет из себя стандартную игру Tower Defence. Ваша главная задача не дать троллям пройти весь путь.
Главный правила игры: