Skip to content

fix Issue #8 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fpkon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix Issue #8 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/SiderealPlanets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,11 @@ boolean SiderealPlanets::setGMTdate(int year, int month, int day) {
}

boolean SiderealPlanets::setGMTtime(int hours, int minutes, float seconds) {
if (GMThour == hours && GMTminute == minutes && GMTseconds == seconds) return true; //Already done
//if (GMThour == hours && GMTminute == minutes && GMTseconds == seconds) return true; //Already done
//After setLocalTime() (GMThour == hours) is always true, but GMTtime might still be at another hour.
// If you return from here, the new GMTtime will not be set in line 307, so GMThour and GMTtime might have different hours.
// This produced the error in Issue #8 on 2023-10-01. The time was set to 23-00-00, but the above if statement was true and GMTtime not set as expected.
*/
if (hours < 0 || hours > 23)
return false;
else
Expand Down