Protocol Export from protocol developer#350
Open
Rohit-Kannachel wants to merge 1 commit intofeat-nysbc-feedbackfrom
Open
Protocol Export from protocol developer#350Rohit-Kannachel wants to merge 1 commit intofeat-nysbc-feedbackfrom
Rohit-Kannachel wants to merge 1 commit intofeat-nysbc-feedbackfrom
Conversation
…a easier to read yaml file from protocol developer
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a streamlined “Export Base Protocol” feature to the Fibsem milling stage editor, allowing users to dump core milling settings into a simplified YAML template.
- Imported a file‐save dialog helper.
- Added an “Export as Base Protocol” button to the widget.
- Implemented
export_base_protocolto deep‐copy the current protocol and save it.
Comments suppressed due to low confidence (3)
fibsem/ui/FibsemMillingStageEditorWidget.py:1258
- [nitpick] This helper method appears to be private, but isn’t prefixed with an underscore. For consistency with
_initialise_widgets, consider renaming to_export_base_protocol.
def export_base_protocol(self):
fibsem/ui/FibsemMillingStageEditorWidget.py:1258
- The new
export_base_protocolworkflow isn’t exercised by existing tests. Consider adding a unit test that mocks the save dialog and validates the emitted YAML output to maintain coverage.
def export_base_protocol(self):
fibsem/ui/FibsemMillingStageEditorWidget.py:1267
- The code uses
copy.deepcopybut there is noimport copyin this file, which will raise a NameError. Please addimport copyat the top.
current_milling_dict = copy.deepcopy(selected_lamella.protocol)
patrickcleeve2
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to implement a less complex protocol export function to create an easier to read yaml file from protocol developer