Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

Conversation

@peaceheis
Copy link

No description provided.

@peaceheis peaceheis requested a review from a team July 31, 2022 23:16
Copy link
Member

@woodiertexas woodiertexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective.

Edit: Turns out I accidentally approved the whole PR instead of the version bump edits.

Copy link
Contributor

@violet-sh violet-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment I made LGTM

@@ -1,38 +1,5 @@
package io.github.debuggyteam.wonders.util;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this file still exists?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking the stuff that used to exist in the utils file got moved or will have a different implementation. Currently this is what exists in the main repo: https://github.com/DebuggyTeam/wonders/blob/1.19/src/main/java/io/github/debuggyteam/wonders/util/WondersUtils.java

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, however in that case shouldn't it just be yeeted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, I'll ask snooze about it on the dev chat since snooze was the one who made the PR.

Copy link
Member

@woodiertexas woodiertexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me despite some stuff being unfinished. Also I'm very late on this.

@woodiertexas woodiertexas changed the base branch from 1.19 to testing December 19, 2022 03:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants