-
Notifications
You must be signed in to change notification settings - Fork 2
Clean Up Codebase and Start Boulders #1
base: testing
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective.
Edit: Turns out I accidentally approved the whole PR instead of the version bump edits.
violet-sh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the comment I made LGTM
| @@ -1,38 +1,5 @@ | |||
| package io.github.debuggyteam.wonders.util; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this file still exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking the stuff that used to exist in the utils file got moved or will have a different implementation. Currently this is what exists in the main repo: https://github.com/DebuggyTeam/wonders/blob/1.19/src/main/java/io/github/debuggyteam/wonders/util/WondersUtils.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, however in that case shouldn't it just be yeeted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, I'll ask snooze about it on the dev chat since snooze was the one who made the PR.
woodiertexas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me despite some stuff being unfinished. Also I'm very late on this.
No description provided.